Differentiate between lib and lib64 in modules #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
reviewed
Feb 8, 2021
|
I like the changes. |
Check if building MPI, compiler, or CMake and if so don't run configure_file on module Move CMake script into generate file
|
@aerorahul I added a check if building |
aerorahul
approved these changes
Feb 9, 2021
|
|
||
| # Install the module with configure_file, replacing ${CMAKE_INSTALL_LIBDIR} (and potentially other variables) | ||
| # with the actual value for that system | ||
| $SUDO cmake -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR} \ |
There was a problem hiding this comment.
This is good.
I would just note that we will need more template variables e.g. PYTHON_VERSION in bufr.lua.
We can address that in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding
lib, make it a templated value and at module installation detectCMAKE_INSTALL_LIBDIRand fill it into the module usingconfigure_file.