Fixed issue #46
Merged
Fixed issue #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not currently setup for C++. Will give it a shot when I can. Thanks! |
|
Works. Thanks! |
SinghRajenM
force-pushed
the
src_FixedIssue_20181209
branch
2 times, most recently
from
5de0a03 to
458dba6
Compare
SinghRajenM
force-pushed
the
src_FixedIssue_20181209
branch
from
458dba6 to
5bce57c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #43
const char* FALSE_STR = "false";sizeof(NULL_STR)give the size of pointer instead of the string (char array). So this issue may not be seen inx64 bit as
sizeofpointer in x64 is 8 whereas 4 in x86.Use
strlento get the length of the string.