Conversation
…. We'll need to make an issue to deal with the longer term impact of this boundary, but this at least prevent throwing errors.
Collaborator
|
@jmaguire1 I think I should test this with a few homes before merging. Do you have an example from BEopt you can send? |
Collaborator
Author
|
@mnblonsky: Agreed, it's probably a good idea. Here's a home with no garage, one that partially protrudes, and one that fully protrudes from BEopt 3.0, for 1 and 2 story homes. I think this pretty much covers everything we intend to support, but if we run into any errors we'll figure out a fix: no_garage.zip |
Collaborator
|
Tested all the 5 cases - home with no garage, one that partially protrudes, and one that fully protrudes for 1 and 2 story homes and it ran successfully. |
mnblonsky
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #96. This might not be the end all be all fix here, but we're accounting now for situations where the garage and attic have a shared boundary. We're not updating the RC network, so basically neglecting the heat transfer between the two unconditioned zones, but that seems to be a pretty reasonable assumption.
Also added "living space" to the list of potential conditioned zones, since someone changed the name at some point.