Conversation
This was referenced Jan 25, 2018
nllong
approved these changes
Jan 26, 2018
Member
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
looks good. one small change if you can.
I will look into fixing the CI machines.
| analysis_type: a.analysis_type, | ||
| run_flag: a.run_flag, | ||
| exit_on_guideline_14: a.exit_on_guideline_14, | ||
| total_datapoints: a.data_points.where(:status.in => job_statuses).only(:id).count, |
Member
There was a problem hiding this comment.
we really need to go and clean up all the two word data_points.
|
|
||
| var color = d3.scale.category10(); | ||
|
|
||
| var excludedData = ['wwr_west_static', 'data_point_uuid', '_id', 'name', 'run_start_time', 'run_end_time', 'status', 'status_message']; |
Member
There was a problem hiding this comment.
We need to populate this list from some sort of metadata item in the variable list.
- remove wwr_west_static -- that is way to custom. I realize that is mine from years ago :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for issues #243 (scatter plot) and #258 (parallel coords plot).
Also added key 'total_datapoints' to analysis status.json