Add ValueCurves from PowerSystems to infrasys #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jerrypotts
commented
Jul 9, 2024
jerrypotts
commented
- Added classes for InputOutputCurve, IncrementalCurve, and AverageRateCurve that call function_data classes to build generic cost curves. These classes are analogous to the structs found in PowerSystems
- Added functions to convert between the different value_curves classes (ex: InputOutputToIncremental creates an IncrementalCurve from an existing InputOutputCurve)
- Added functions to function_data to perform calculations for value_curve conversion
- Added additional serialization tests to test_function_data
daniel-thom
reviewed
Aug 5, 2024
Collaborator
daniel-thom
left a comment
daniel-thom
left a comment
There was a problem hiding this comment.
I made a cursory pass and have two minor comments.
pesap
requested changes
Aug 13, 2024
Collaborator
pesap
left a comment
pesap
left a comment
There was a problem hiding this comment.
LGTM. If you address the changes we can merge it right away.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
… to infrasys (#38) - Added classes for InputOutputCurve, IncrementalCurve, and AverageRateCurve that call function_data classes to build generic cost curves. These classes are analogous to the structs found in PowerSystems - Added functions to convert between the different value_curves classes (ex: InputOutputToIncremental creates an IncrementalCurve from an existing InputOutputCurve) - Added functions to function_data to perform calculations for value_curve conversion - Added additional serialization tests to test_function_data --------- Co-authored-by: pesap <pesapsanchez@gmail.com>
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.