Skip to content

Update checks of HAS_GPU in tests to handle case where cudf is not installed #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 4, 2023
Merged

Update checks of HAS_GPU in tests to handle case where cudf is not installed #118

merged 6 commits into from
May 4, 2023

Conversation

@oliverholworthy
Copy link
Contributor

@oliverholworthy oliverholworthy commented Mar 28, 2023

Update checks of HAS_GPU to handle case where cudf is not installed. This enables the tests to run in an environment with GPUs, but without cudf installed.

@oliverholworthy oliverholworthy self-assigned this Mar 28, 2023
@karlhigley karlhigley requested review from edknv and jperez999 April 4, 2023 20:56
@edknv edknv added this to the Merlin 23.04 milestone Apr 4, 2023
@karlhigley karlhigley modified the milestones: Merlin 23.04, Merlin 23.05 Apr 25, 2023
@oliverholworthy oliverholworthy merged commit d9e97b4 into NVIDIA-Merlin:main May 4, 2023
@oliverholworthy oliverholworthy deleted the has-gpu-and-cudf branch May 4, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jperez999 jperez999 jperez999 approved these changes

@edknv edknv edknv approved these changes

Assignees

@oliverholworthy oliverholworthy

Labels

chore

Projects

None yet

Milestone

Merlin 23.05

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverholworthy @jperez999 @edknv @karlhigley