Skip to content

remove numpy tensorflow conversion logic in tf dataloader #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

remove numpy tensorflow conversion logic in tf dataloader #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions merlin/dataloader/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from merlin.core.compat import tensorflow as tf
from merlin.dataloader.array import ArrayLoader
from merlin.table import Device, NumpyColumn, TensorColumn, TensorflowColumn, TensorTable
from merlin.table import TensorColumn, TensorflowColumn, TensorTable
from merlin.table.conversions import _dispatch_dlpack_fns, convert_col


Expand Down Expand Up @@ -104,7 +104,6 @@ def convert_batch(self, batch):
tf_inputs = {}
if inputs is not None:
inputs_table = self.create_table(inputs)
column_type = TensorflowColumn if Device.GPU == inputs_table.device else NumpyColumn
for col_name, col in inputs_table.items():
tf_inputs[col_name] = self.convert_col(col, column_type)

Expand Down