Remove reset of dataloader in len method of ArrayLoader
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reset of the loader was only required for the Keras Sequence dataloader.
karlhigley
approved these changes
Apr 4, 2023
oliverholworthy
force-pushed
the
remove-len-reset
branch
from
2a84859 to
2718629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #111 removing the reset of the dataloader (call to the
stopmethod) inside the__len__method ofArrayLoader.This loader reset in the len method caused some infinte loops in Transformers4Rec where we call len on the dataloader during it's iteration in an
evaluation_loopmethod of the trainer.