Apply map function when peeking in tensorflow #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edknv
force-pushed
the
map_when_peek
branch
3 times, most recently
from
9719942 to
c797261
Compare
| without removing it from the queue""" | ||
| return self.convert_batch(self._peek_next_batch()) | ||
| converted_batch = self.convert_batch(self._peek_next_batch()) | ||
| for map_fn in self._map_fns: |
Contributor
There was a problem hiding this comment.
looks like the same applies to the peek method of the torch dataloader too. Would it work to move these methods (__next__/peek) to the base class like we had before?
Contributor
There was a problem hiding this comment.
either in this PR or a new one.
Contributor
Author
There was a problem hiding this comment.
Thanks, that's a good point. I'll follow up with a new PR.
oliverholworthy
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.peek()is supposed to produce the same output asnext()without advancing the iterator:dataloader/merlin/dataloader/tensorflow.py
Lines 80 to 86 in 699ca7b
but the
.map()functionality inpeek()got dropped after the recent dataloader changes, while__next__still applies the map function properly. This PR applies the same logic currently in__next__topeek(). Models currently makes use of this combination:map()andpeek().