Skip to content

Put values and offsets on the same device on gpu #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Put values and offsets on the same device on gpu #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d71c3
Put values and offsets on the same device on gpu
edknv Nov 10, 2022
cef18de
pass environ var in tox
edknv Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion merlin/loader/torch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _pull_values_offsets(self, values_offset):
offsets = torch.arange(values.size()[0], device=self.device)
num_rows = len(offsets)
if HAS_GPU:
offsets = torch.cat([offsets, torch.cuda.LongTensor([len(values)])])
offsets = torch.cat([offsets, torch.cuda.LongTensor([len(values)], device=self.device)])
else:
offsets = torch.cat([offsets, torch.LongTensor([len(values)])])
diff_offsets = offsets[1:] - offsets[:-1]
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ commands =
python -m pytest --cov-report term --cov=merlin -rxs tests/unit

[testenv:test-gpu]
passenv =
NR_USER
Comment on lines +26 to +27
Copy link
Contributor Author

@edknv edknv Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tox blocks all environment variables by default. We need to pass this in order to skip this test that uses horovod. The test was skipped previously because horovod was not installed in the ci runner image, but horovod was recently installed in the ci runner image because of multi-gpu support in Models.

sitepackages=true
; Runs in: Internal Jenkins
; Runs GPU-based tests.
Expand Down