Skip to content

Conversation

@mikemckiernan
Copy link
Collaborator

@mikemckiernan mikemckiernan commented Feb 19, 2025

Description

Originally, I thought the pre-0.13.0 streaming information was obsolete. I've since learned that there's streaming with output rails and without output rails. I do not know the details of how streaming works without output rails, but it was important to remove the statement that streaming is not supported with output rails.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Feb 19, 2025
@mikemckiernan mikemckiernan self-assigned this Feb 19, 2025
@github-actions
Copy link
Contributor

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1007

@Pouyanpi
Copy link
Collaborator

@mikemckiernan I think this part of the old doc is useful. What do you think?

It is somehow mentioned here

@mikemckiernan mikemckiernan force-pushed the mmck-redirect-streaming branch from 58d9832 to 0010c98 Compare May 8, 2025 15:01
@mikemckiernan mikemckiernan changed the title docs: Redirect streaming content to new material docs: Output rails are supported with streaming May 8, 2025
@mikemckiernan mikemckiernan added this to the v0.14.0 milestone May 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.24%. Comparing base (b65cf0e) to head (efa5639).
⚠️ Report is 63 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1007   +/-   ##
========================================
  Coverage    68.24%   68.24%           
========================================
  Files          161      161           
  Lines        15938    15938           
========================================
  Hits         10877    10877           
  Misses        5061     5061           
Flag Coverage Δ
python 68.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
@mikemckiernan mikemckiernan force-pushed the mmck-redirect-streaming branch from 0010c98 to efa5639 Compare May 8, 2025 15:17
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍🏻

@Pouyanpi Pouyanpi merged commit 002a520 into NVIDIA-NeMo:develop May 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants