Skip to content

Conversation

@miyoungc
Copy link
Collaborator

@miyoungc miyoungc commented Jul 8, 2025

Description

Fix the advanced jailbreak deployment doc to appear

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@miyoungc miyoungc requested a review from erickgalinkin July 8, 2025 20:16
@miyoungc miyoungc self-assigned this Jul 8, 2025
@miyoungc miyoungc added the documentation Improvements or additions to documentation label Jul 8, 2025
@miyoungc miyoungc added this to the v0.14.1 milestone Jul 8, 2025
@miyoungc miyoungc requested review from Pouyanpi and tgasser-nv July 8, 2025 20:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1276

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.59%. Comparing base (ba4c321) to head (077d0bb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1276   +/-   ##
========================================
  Coverage    69.59%   69.59%           
========================================
  Files          161      161           
  Lines        16029    16029           
========================================
  Hits         11156    11156           
  Misses        4873     4873           
Flag Coverage Δ
python 69.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miyoungc, lgtm. I assume jailbreak heuristics does not need to be in toc, right? Or is it being referenced somewhere else?

Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miyoungc
Copy link
Collaborator Author

miyoungc commented Jul 9, 2025

Thank you @miyoungc, lgtm. I assume jailbreak heuristics does not need to be in toc, right? Or is it being referenced somewhere else?

@Pouyanpi It's been hidden in the repository and was never referenced. I added it to TOC cause I had an impression that we wanted to make this page to appear in the public doc.

@miyoungc miyoungc merged commit 8c663c8 into NVIDIA-NeMo:develop Jul 9, 2025
42 checks passed
Pouyanpi pushed a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants