Skip to content

Conversation

@miyoungc
Copy link
Collaborator

@miyoungc miyoungc commented Aug 13, 2025

Description

Add documentation for kv cache reuse for NemoGuard NIMs.

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@miyoungc miyoungc self-assigned this Aug 13, 2025
@miyoungc miyoungc added the documentation Improvements or additions to documentation label Aug 13, 2025
@github-actions
Copy link
Contributor

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1330

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.61%. Comparing base (6ba7832) to head (a5ce6eb).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1330      +/-   ##
===========================================
+ Coverage    70.58%   70.61%   +0.02%     
===========================================
  Files          161      161              
  Lines        16291    16304      +13     
===========================================
+ Hits         11499    11513      +14     
+ Misses        4792     4791       -1     
Flag Coverage Δ
python 70.61% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@tgasser-nv tgasser-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small tweaks needed before merging. Thanks!

@miyoungc miyoungc merged commit 3018024 into NVIDIA-NeMo:develop Aug 15, 2025
9 checks passed
Pouyanpi pushed a commit that referenced this pull request Oct 1, 2025
* add kv caching draft

* generalize string placeholders

* minor edits

* minor edits

* incorporate feedback

* sneak in link open new tab functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants