Skip to content

Conversation

@nicoloboschi
Copy link
Contributor

No description provided.

@drazvan drazvan self-requested a review June 7, 2024 12:30
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @nicoloboschi!
I've tested locally as well and nothing seems to break.

@drazvan
Copy link
Collaborator

drazvan commented Jun 7, 2024

@nicoloboschi : before I can merge, you need to sign your commits (https://github.com/NVIDIA/NeMo-Guardrails/blob/develop/CONTRIBUTING.md#submitting-your-work).

@nicoloboschi
Copy link
Contributor Author

Hey @drazvan I've force pushed with a signed commit this time, should be good to go!

@drazvan drazvan merged commit b6ad06a into NVIDIA-NeMo:develop Jun 7, 2024
@nicoloboschi nicoloboschi deleted the allow-langchain2 branch June 7, 2024 14:10
@Pouyanpi Pouyanpi linked an issue Jun 8, 2024 that may be closed by this pull request
@Pouyanpi Pouyanpi mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support langchain 0.2.*

2 participants