-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Related to HiFiGAN/PyTorch
Describe the bug
The number of Mel filters is configurable in HiFiGAN/train.py, using the input arguments. However, in the file HiFiGAN/hifigan/models.py, where the HiFiGAN model is defined, this number is hard-coded to the default of 80. So any non-default value will raise an error. There are 2 places:
| Conv1d(80, conf.upsample_initial_channel, 7, 1, padding=3)) |
| mel_input = mel_init((1, 80, 88), dtype=w.dtype, device=w.device) |
To Reproduce
Run the training code (train.py) with non-default value of --num_mels argumnet.
To Fix
- In
HiFiGAN/models.py:get_moel_configmethod, add the value ofargs.num_melsto themodel_configdictionary - In
Generatorclass from the filehifigan/models.py(line 151), use the value from the config (instead of the hard coded "80") - Repeat for the
Denoiserclass from same file (line 250)
Environment
- Container version : pytorch 21.12-py3
- GPUs in the system : 8x A40
- CUDA driver version : 11.8
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working