Skip to content

MaxText: fix test script, workaround broken tf wheel #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

MaxText: fix test script, workaround broken tf wheel #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/container/Dockerfile.maxtext
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ for pattern in \
"s|protobuf==3.20.3|protobuf>=3.19.0|g" \
"s|tensorflow-datasets|tensorflow-datasets>=4.8.0|g" \
"s|sentencepiece==0.1.97|sentencepiece>=0.2|g" \
"s|tensorflow>=2.13.0|tensorflow==2.18.1|g" \
; do
# tensorflow-cpu==2.19.0 is incompatible with tensorflow-text
sed -i "${pattern}" ${SRC_PATH_MAXTEXT}/requirements.txt;
done
# add new line in case requirements.txt does not end with a new line
Expand Down
8 changes: 3 additions & 5 deletions .github/container/test-maxtext.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,7 @@ RUN_NAME="logdir" ## the RUN_NAME cannot be changed
if [ -z "$DECODER_BLOCK" ]; then

# this part could be used to test different model ootb
RUN_SETTINGS="MaxText/train.py \
MaxText/configs/base.yml \
RUN_SETTINGS="MaxText/configs/base.yml \
run_name=${RUN_NAME} \
model_name=${MODEL} \
steps=${STEPS} \
Expand All @@ -277,8 +276,7 @@ if [ -z "$DECODER_BLOCK" ]; then
${ADDITIONAL_ARGS}"
else
# this is essentially used for CI run
RUN_SETTINGS="MaxText/train.py \
MaxText/configs/base.yml \
RUN_SETTINGS="MaxText/configs/base.yml \
run_name=${RUN_NAME} \
decoder_block=${DECODER_BLOCK} \
steps=$STEPS \
Expand Down Expand Up @@ -310,6 +308,6 @@ else
fi

echo "Command: python3 $RUN_SETTINGS"
python3 $RUN_SETTINGS
python3 -m MaxText.train $RUN_SETTINGS

echo "Output at ${OUTPUT}"
Loading