Add comprehensive logging system and exception disabling support #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipped: This PR changes more files than the configured file change limit: ( |
Collaborator
Author
|
/build |
1 similar comment
Collaborator
Author
|
/build |
Enhances MatX's observability and error handling
capabilities by adding extensive logging throughout the codebase and providing
an option to disable exceptions.
Logging enhancements:
- Added TRACE-level logging to all operator and generator constructors
- Log operator name via str() method and relevant constructor parameters
- Consolidated log.h include in base_operator.h to reduce duplication
- Added DEBUG-level logging for cache operations
- Log cache hits and misses in LookupAndExec with cache ID, device, and thread
- Log transform-specific cache attempts with descriptive names (FFT, MatMul,
SVD, QR, LU, Eigenvalue, Inverse, CUB, Einsum, Solve, Sparse conversions,
Filter, Covariance)
- Added DEBUG-level logging for kernel launches
- Log kernel parameters in CUDA executor
- Added DEBUG-level logging for memory operations
- Log all tensor allocations and deallocations with pointer and size info
- Log all make_tensor() calls with signature, shape, pointer, and memory kind
- Converted all printf/fprintf calls in error.h to use MatX logger
- Error messages now use MATX_LOG_ERROR/MATX_LOG_FATAL consistently
- Changed default log level from OFF to ERROR
- Ensures error messages are visible by default
- Users can override via MATX_LOG_LEVEL environment variable
Exception handling improvements:
- Added MATX_DISABLE_EXCEPTIONS CMake option
- When enabled, MATX_THROW logs fatal error and calls abort() instead of throwing
- Provides exception-free operation for environments that don't support them
- All error handling macros automatically adapt to exception-disabled mode
- Fixed macro parameter naming to avoid preprocessor conflicts
These changes enable detailed runtime diagnostics for debugging performance
issues, cache behavior, and memory usage while maintaining zero overhead when
logging is disabled.
cliffburdick
force-pushed
the
more_logging
branch
from
a263dc0 to
c8132ce
Compare
Collaborator
Author
|
/build |
1 task
Collaborator
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances MatX's observability and error handling
capabilities by adding extensive logging throughout the codebase and providing an option to disable exceptions.
Logging enhancements:
Exception handling improvements:
These changes enable detailed runtime diagnostics for debugging performance issues, cache behavior, and memory usage while maintaining zero overhead when logging is disabled.