Skip to content

Conversation

@rapids-bot
Copy link

@rapids-bot rapids-bot bot commented Sep 30, 2025

Forward-merge triggered by push to release/1.3 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Yuchen Zhang (https://github.com/yczhang-nv)
  - Eric Evans II (https://github.com/ericevans-nv)
  - Will Killian (https://github.com/willkill07)

URL: #877
@rapids-bot rapids-bot bot requested a review from a team as a code owner September 30, 2025 20:01
@rapids-bot
Copy link
Author

rapids-bot bot commented Sep 30, 2025

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (26353b3) to head (85ddbd0).
⚠️ Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #880      +/-   ##
===========================================
- Coverage    77.08%   77.06%   -0.03%     
===========================================
  Files          444      444              
  Lines        26610    26635      +25     
===========================================
+ Hits         20513    20526      +13     
- Misses        6097     6109      +12     
Flag Coverage Δ
unittests 77.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dagardner-nv and others added 2 commits September 30, 2025 20:21
* Include branch name in nightly test report, allowing us to distinguish `develop` from `release/1.3` test reports
* Set code rabbit to review additional non-default branches

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **New Features**
  * Test result summaries now include the source branch name and a revised date placement in both plain text and block formats, improving clarity in CI reports.

* **Chores**
  * Updated auto-review configuration to restrict target base branches to development and release patterns for more focused reviews.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: #879
…ex (#881)

This PR extends the LiteLLM type introduced in #726 to be supported in other frameworks.

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.



## Summary by CodeRabbit

- **New Features**
  - Added LiteLLM as a supported LLM provider across AGNO, CrewAI, LangChain, LangChain, and LlamaIndex integrations.
  - Enables configuring LiteLLM with common parameters (model_name, api_key, base_url, seed, temperature, top_p, max_retries).

- **Documentation**
  - Updated LLM providers table and added LiteLLM setup/config guidance, including Azure OpenAI area and workflows docs.

- **Chores**
  - Added runtime dependencies for LiteLLM integrations (LangChain, LlamaIndex) and suppresses transformers warnings in the CLI.

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)
  - https://github.com/Salonijain27

URL: #881
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 1, 2025 01:50
willkill07 and others added 6 commits October 1, 2025 13:46
Updates the ADK Demo example to work.

* add missing registration imports
* exactly specify `framework_wrappers`

Closes nvbugs-5554110

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **New Features**
  * Enabled ADK framework support in the demo: City Time and Weather Update tools are now registered for ADK, making them discoverable and usable in ADK-based workflows and integrations.
  * Improves out-of-the-box experience for ADK users running the examples by ensuring these tools are available without additional configuration.

* **Chores**
  * Updated tool registrations to target the ADK framework while keeping existing function behavior and signatures unchanged.

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: #885
Fixes minor issue with documentation for the email phishing analyzer example

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.



## Summary by CodeRabbit

* **Documentation**
  * Outputs section updated: added optimized configuration file, per-iteration numeric trial configs, full trials dataframe export, Pareto visualization plots, and explicit per-generation prompt history files alongside existing prompt artifacts.
* **Chores**
  * Accepted vocabulary list updated to include the term "Pareto".

Authors:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: #884
Updating all package references with square brackets to be properly quoted in README files.
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.



## Summary by CodeRabbit

- **Documentation**
  - Standardized installation instructions to quote package extras (e.g., "nvidia-nat[langchain]", "nvidia-nat[all]", "nvidia-nat[profiling]", "nvidia-nat[mcp]") across README, quick start, workflows, reference docs, and examples; updated code blocks and usage snippets accordingly.

- **Chores**
  - Minor formatting and whitespace adjustments in example configs and installer hint/error message text to use quoted package specs.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: #886
)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Documentation**
  * Added guidance to the MCP client tool listing explaining SSE transport requirements: the server must be started with --transport sse, client and server transports must match, and the default transport is streamable-http.
  * Clarifies setup expectations to reduce misconfiguration and aid onboarding and troubleshooting.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: #887
Command was failing with the following exception -
```
nat mcp client tool list --url http://localhost:9901/mcp

None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
2025-10-01 09:32:08,068 - nat.plugins.mcp.client_impl - INFO - Configured to use MCP server at streamable-http:http://localhost:9901/mcp
2025-10-01 09:32:08,332 - mcp.client.streamable_http - INFO - Received session ID: d37fbec957d8484caebf69a8767d5498
2025-10-01 09:32:08,336 - mcp.client.streamable_http - INFO - Negotiated protocol version: 2025-06-18
2025-10-01 09:32:08,453 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,471 - nat.plugins.mcp.client_impl - INFO - Adding tool calculator_multiply to group
2025-10-01 09:32:08,497 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,526 - nat.plugins.mcp.client_impl - INFO - Adding tool calculator_inequality to group
2025-10-01 09:32:08,540 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,550 - nat.plugins.mcp.client_impl - INFO - Adding tool current_datetime to group
2025-10-01 09:32:08,572 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,580 - nat.plugins.mcp.client_impl - INFO - Adding tool calculator_divide to group
2025-10-01 09:32:08,594 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,608 - nat.plugins.mcp.client_impl - INFO - Adding tool calculator_subtract to group
2025-10-01 09:32:08,624 - nat.builder.function_info - WARNING - Using provided input_schema for multi-argument function
2025-10-01 09:32:08,630 - nat.plugins.mcp.client_impl - INFO - Adding tool react_agent to group
Traceback (most recent call last):
  File "/home/devcontainers/dev/forks/nat/.venv/bin/nat", line 10, in <module>
    sys.exit(run_cli())
             ~~~~~~~^^
  File "/home/devcontainers/dev/forks/nat/src/nat/cli/main.py", line 40, in run_cli
    cli(obj={}, auto_envvar_prefix='NAT', show_default=True, prog_name="nat")
    ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1363, in main
    rv = self.invoke(ctx)
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  [Previous line repeated 1 more time]
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/core.py", line 794, in invoke
    return callback(*args, **kwargs)
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/click/decorators.py", line 34, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/devcontainers/dev/forks/nat/src/nat/cli/commands/mcp/mcp.py", line 574, in mcp_client_tool_list
    tools = asyncio.run(
        list_tools_via_function_group(command,
    ...<6 lines>...
                                      auth_user_id=auth_user_id,
                                      auth_scopes=auth_scopes_list))
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/nest_asyncio.py", line 30, in run
    return loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/devcontainers/dev/forks/nat/.venv/lib/python3.13/site-packages/nest_asyncio.py", line 98, in run_until_complete
    return f.result()
           ~~~~~~~~^^
  File "/home/devcontainers/.local/share/uv/python/cpython-3.13.1-linux-x86_64-gnu/lib/python3.13/asyncio/futures.py", line 199, in result
    raise self._exception.with_traceback(self._exception_tb)
  File "/home/devcontainers/.local/share/uv/python/cpython-3.13.1-linux-x86_64-gnu/lib/python3.13/asyncio/tasks.py", line 306, in __step_run_and_handle_result
    result = coro.throw(exc)
  File "/home/devcontainers/dev/forks/nat/src/nat/cli/commands/mcp/mcp.py", line 300, in list_tools_via_function_group
    for full, fn in (await fns).items():
                     ^^^^^^^^^
TypeError: object dict can't be used in 'await' expression
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

- New Features
  - Added LiteLLM provider support across AGNO, CrewAI, LangChain, and LlamaIndex.
- Documentation
  - Quoted extras in install commands for better shell/Windows compatibility.
  - Added MCP Authentication guide; linked from MCP client/server and noted limitations.
  - Documented LiteLLM provider and configuration.
  - Expanded evaluation/profiling outputs description.
- Improvements
  - CLI now suppresses Transformers warnings.
- Examples
  - ADK demo tools registered for ADK framework; MCP and RAG examples updated with quoted installs.
- Chores
  - Nightly test summary now includes branch name and date.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Zhongxuan (Daniel) Wang (https://github.com/zhongxuanwang-nv)
  - David Gardner (https://github.com/dagardner-nv)

URL: #888
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.




## Summary by CodeRabbit

* **Documentation**
  * Updated the prerequisite installation link in the getting-started tutorial to the official NVIDIA NeMo installation guide.
  * Instructions now reflect the current source repository and install-from-source steps.
  * This change affects only the tutorial text; code cells are unchanged.
  * No behavioral or API changes; notebooks continue to run as before.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Yuchen Zhang (https://github.com/yczhang-nv)

URL: #890
@dagardner-nv dagardner-nv self-assigned this Oct 1, 2025
@dagardner-nv dagardner-nv added the DO NOT MERGE PR should not be merged; see PR for details label Oct 1, 2025
@dagardner-nv
Copy link
Contributor

Hold until versions are resolved in release/1.3

…atch." (#892)

Reverts #887



## Summary by CodeRabbit

- Documentation
  - Updated versions: removed 1.4 and marked 1.3 as the preferred version.
  - Simplified MCP client docs by removing SSE transport prerequisite note.

- Chores
  - Standardized dependencies across examples and packages to nvidia-nat ~=1.3 (including extras such as langchain, mcp, ingestion, mem0ai, adk, agno, telemetry/opentelemetry, profiling, weave, redis, mysql, s3, zep-cloud, llama-index, crewai, semantic-kernel, litellm, gunicorn, async_endpoints).
  - Adjusted extras ordering where applicable without functional impact.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #892
@dagardner-nv dagardner-nv merged commit 7c80936 into develop Oct 1, 2025
16 of 17 checks passed
@dagardner-nv dagardner-nv deleted the release/1.3 branch October 1, 2025 20:06
@dagardner-nv dagardner-nv restored the release/1.3 branch October 1, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE PR should not be merged; see PR for details

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants