Skip to content

Conversation

@guyueh1
Copy link
Contributor

@guyueh1 guyueh1 commented Mar 21, 2025

This should only be used with a recent nsys version.

Copy link
Contributor

@hemildesai hemildesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to extract all these args to a nsys_extra_args attr on the Launcher? This way it will become configurable and will be easier in the future to add/remove args.

@guyueh1
Copy link
Contributor Author

guyueh1 commented Apr 7, 2025

Is it possible to extract all these args to a nsys_extra_args attr on the Launcher? This way it will become configurable and will be easier in the future to add/remove args.

@hemildesai I put the nsys arguments to a variable named nsys_extra_args, so that users can configure it if they want. Please review again;
Also, the Ruff format and the wheel build failure seem not relevant to my change, do we need to bump the version number to make Ruff pass? And can you tell why the wheel build is failing?

Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
@hemildesai hemildesai merged commit 1f79d9c into NVIDIA-NeMo:main Apr 8, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants