Skip to content

Conversation

folivoramanh
Copy link

  • Fix Jenkinsfile for CI

  • Fix requirements for test

  • Update paths and docker

  • Fix docker name

  • Fix click version

  • Change path of grammars for sparrowhawk tests

  • Update paths in sh_test.sh

  • Update paths

  • Revert paths


What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

@folivoramanh folivoramanh changed the base branch from staging_vi_tn to main September 24, 2025 02:50
@folivoramanh folivoramanh changed the base branch from main to staging_vi_tn September 24, 2025 02:50
* Fix Jenkinsfile for CI

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Fix requirements for test

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Update paths and docker

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Fix docker name

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Fix click version

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Change path of grammars for sparrowhawk tests

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Update paths in sh_test.sh

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Update paths

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Revert paths

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

---------

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Signed-off-by: folivoramanh <palasek182@gmail.com>
Copy link

github-actions bot commented Oct 9, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 9, 2025
@mgrafu mgrafu merged commit 9c19009 into NVIDIA:staging_vi_tn Oct 10, 2025
2 checks passed
@folivoramanh folivoramanh deleted the staging_vi_tn_v1 branch October 13, 2025 15:56
mgrafu pushed a commit that referenced this pull request Oct 16, 2025
* Fix Jenkinsfile for CI

* Fix requirements for test

* Update paths and docker

* Fix docker name

* Fix click version

* Change path of grammars for sparrowhawk tests

* Update paths in sh_test.sh

* Update paths

* Revert paths

---------

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Signed-off-by: folivoramanh <palasek182@gmail.com>
Co-authored-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants