Skip to content

Conversation

mgrafu
Copy link
Collaborator

@mgrafu mgrafu commented Sep 25, 2025

What does this PR do ?

fix a bug that caused incorrect normalization through electronics:

in: "There are 5.4, or 5.5"
out: "There are five dot four comma or five point five"
expected/fix: "There are five point four, or five point five"

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

mgrafu and others added 2 commits September 25, 2025 13:56
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
for more information, see https://pre-commit.ci

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
@mgrafu mgrafu requested a review from tbartley94 September 25, 2025 20:58
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Copy link
Collaborator

@tbartley94 tbartley94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgrafu mgrafu merged commit e15caea into main Sep 25, 2025
4 checks passed
mgrafu added a commit that referenced this pull request Oct 16, 2025
* fix bug with commas and electronics

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update jenkins

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
folivoramanh pushed a commit to folivoramanh/NeMo-text-processing that referenced this pull request Oct 21, 2025
* fix bug with commas and electronics

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

* update jenkins

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>

---------

Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mariana Graterol Fuenmayor <marianag@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants