Skip to content

Conversation

@marta-sd
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

marta-sd added 2 commits May 20, 2025 08:27
Signed-off-by: martas <martas@nvidia.com>
Signed-off-by: martas <martas@nvidia.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @marta-sd 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label May 20, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @marta-sd 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@marta-sd marta-sd self-assigned this May 20, 2025
Signed-off-by: martas <martas@nvidia.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @marta-sd 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label May 20, 2025
@ko3n1g ko3n1g merged commit d4ac2a6 into main May 20, 2025
85 checks passed
@ko3n1g ko3n1g deleted the martas/eval-tests-fix branch May 20, 2025 18:22
shjwudp pushed a commit to shjwudp/NeMo that referenced this pull request May 31, 2025
* try to set HF_DATASETS_OFFLINE=1 for eval tests

Signed-off-by: martas <martas@nvidia.com>

* set CUDA_VISIBLE_DEVICES=0 too

Signed-off-by: martas <martas@nvidia.com>

* set HF_DATASETS_CACHE and run all eval tests

Signed-off-by: martas <martas@nvidia.com>

---------

Signed-off-by: martas <martas@nvidia.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants