Skip to content

Conversation

@senstella
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes bias handling in change_attention_model to preserve original attention's bias configuration instead of always assuming use_bias=True.

Collection: ASR

Changelog

  1. Add the self.use_bias class attribute in ConformerEncoder
  2. Use that to set the correct use_bias value for new attentions when calling change_attention_model

Usage

None

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

None

Signed-off-by: senstella <senstella01@gmail.com>
@github-actions github-actions bot added the ASR label May 22, 2025
@senstella senstella changed the title Fixed incorrect use_bias parameter handling in change_attention_model Fixed incorrect use_bias parameter handling in ConformerEncoder.change_attention_model May 22, 2025
@senstella
Copy link
Author

@titu1994 @redoctopus Hello! When you have a moment, would you mind reviewing this fix? Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jun 6, 2025
@github-actions
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant