updates for model checkpointing for nemotron --> main branch#14539
Closed
rsalagame-nvidia wants to merge 5 commits intomainfrom
Closed
updates for model checkpointing for nemotron --> main branch#14539rsalagame-nvidia wants to merge 5 commits intomainfrom
rsalagame-nvidia wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: rsalagame-nvidia <rsalagame-nvidia@users.noreply.github.com>
nv-mollys
reviewed
Aug 21, 2025
nv-mollys
reviewed
Aug 21, 2025
nv-mollys
reviewed
Aug 21, 2025
| recipe.data.tokenizer = run.Config( | ||
| get_nmt_tokenizer, library="null", model_name="NullTokenizer", vocab_size=256000 | ||
| ) | ||
| if args.hf_token: |
Collaborator
There was a problem hiding this comment.
This should still be args.use_hf_tokenizer.
nv-mollys
reviewed
Aug 21, 2025
| recipe.data.tokenizer = run.Config( | ||
| get_nmt_tokenizer, library="null", model_name="NullTokenizer", vocab_size=256000 | ||
| ) | ||
| if args.hf_token: |
Collaborator
There was a problem hiding this comment.
This should still be args.use_hf_tokenizer.
…exists in place for llmb-nemo-r2.4.0 branch PR.
nv-mollys
approved these changes
Aug 22, 2025
Collaborator
|
@rsalagame-nvidia Apart from Molly's comment, the PR LGTM. |
Contributor
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Contributor
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
This PR resolves checkpointing issue noted in bug: https://nvbugspro.nvidia.com/bug/5459640. Uses HF token to resolve serializable issue for nemotron 15b/340b.
Adds Model Checkpoint definition header to helpers.py and hf token functionality in pretrain scripts.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information