Skip to content

[Fix] Fix the notebook errors on multispeaker data simulation and end to end diarization training #15149

Merged
tango4j merged 3 commits intoNVIDIA-NeMo:mainfrom
tango4j:fix_datasim_noise_gen
Dec 5, 2025
Merged

[Fix] Fix the notebook errors on multispeaker data simulation and end to end diarization training #15149
tango4j merged 3 commits intoNVIDIA-NeMo:mainfrom
tango4j:fix_datasim_noise_gen

Conversation

@tango4j
Copy link
Copy Markdown
Collaborator

@tango4j tango4j commented Dec 5, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix the notebook errors on multispeaker data simulation and end to end diarization training

Collection:

ASR/SpeakerTasks

Changelog

Following files are changed.

nemo/collections/asr/data/data_simulation.py
scripts/speaker_tasks/create_alignment_manifest.py
tutorials/speaker_tasks/End_to_End_Diarization_Training.ipynb
tutorials/tools/Multispeaker_Simulator.ipynb

Usage

Run Notebook files.

tutorials/speaker_tasks/End_to_End_Diarization_Training.ipynb
tutorials/tools/Multispeaker_Simulator.ipynb

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

Anyone in NeMo ASR.

Signed-off-by: tango4j <tango4j@users.noreply.github.com>
@tango4j tango4j added Run CICD and removed Run CICD labels Dec 5, 2025
Copy link
Copy Markdown
Collaborator

@KunalDhawan KunalDhawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": "nemo093025",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe clear the environment name from the notebook?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in the upcoming PR.

@tango4j tango4j merged commit 66ffb38 into NVIDIA-NeMo:main Dec 5, 2025
68 of 74 checks passed
@tango4j tango4j added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Dec 6, 2025
quapham pushed a commit to quapham/NeMo that referenced this pull request Dec 16, 2025
… to end diarization training (NVIDIA-NeMo#15149)

* Fixed the notebook errors

Signed-off-by: taejinp <tango4j@gmail.com>

* Apply isort and black reformatting

Signed-off-by: tango4j <tango4j@users.noreply.github.com>

---------

Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Co-authored-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: quanpham <youngkwan199@gmail.com>
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
… to end diarization training (NVIDIA-NeMo#15149)

* Fixed the notebook errors

Signed-off-by: taejinp <tango4j@gmail.com>

* Apply isort and black reformatting

Signed-off-by: tango4j <tango4j@users.noreply.github.com>

---------

Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Co-authored-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
… to end diarization training (NVIDIA-NeMo#15149)

* Fixed the notebook errors

Signed-off-by: taejinp <tango4j@gmail.com>

* Apply isort and black reformatting

Signed-off-by: tango4j <tango4j@users.noreply.github.com>

---------

Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Co-authored-by: tango4j <tango4j@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR r2.6.0 Cherry-pick label for the r2.6.0 release branch Run CICD Speaker Tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants