Skip to content

Relax kaldialign pin in ASR requirements to unblock Python 3.14 compatibility#15438

Merged
pzelasko merged 4 commits into
NVIDIA-NeMo:mainfrom
basnijholt:relax-kaldialign-pin-for-py314
Mar 19, 2026
Merged

Relax kaldialign pin in ASR requirements to unblock Python 3.14 compatibility#15438
pzelasko merged 4 commits into
NVIDIA-NeMo:mainfrom
basnijholt:relax-kaldialign-pin-for-py314

Conversation

@basnijholt
Copy link
Copy Markdown
Contributor

@basnijholt basnijholt commented Feb 25, 2026

Summary

  • relax kaldialign in requirements/requirements_asr.txt from <=0.9.1 to kaldialign

Context

In PR #14775, commit ce4ad4b changed this requirement from kaldialign>=0.9.2 to kaldialign<=0.9.1 with the message "decrease kaldialign version".

I could not find additional rationale in the PR discussion/review thread, so the reason for the cap is currently not documented for downstream maintainers.

Why This Change

kaldialign now publishes Python 3.14 wheels (e.g. 0.9.3, including cp314).

The <=0.9.1 cap blocks those newer releases, which prevents consumers from resolving newer Python-compatible builds.

Relaxing the cap allows dependency resolution to use current releases and improves Python 3.14 compatibility.

Request For Context

@andrusenkoau if there was a specific compatibility reason for the <=0.9.1 cap, could you share it here? If needed, I can revise this PR to a softer bound (for example <1) instead of fully unbounded.

@basnijholt basnijholt changed the title Relax pin in ASR requirements for newer Python wheel resolution Relax kaldialign pin in ASR requirements to unblock Python 3.14 compatibility Feb 25, 2026
@basnijholt
Copy link
Copy Markdown
Contributor Author

@andrusenkoau Could you share the original reason for pinning kaldialign<=0.9.1 in #14775? I could not find context in the thread, and newer kaldialign releases are needed for clean Python 3.14 compatibility.

@andrusenkoau
Copy link
Copy Markdown
Collaborator

@andrusenkoau Could you share the original reason for pinning kaldialign<=0.9.1 in #14775? I could not find context in the thread, and newer kaldialign releases are needed for clean Python 3.14 compatibility.

Hi @basnijholt,
I had a CI error for arm platform with fresh kaldialign versions. I had no other reason to keep kaldialign<=0.9.1. We can fix this limitation once the tests pass.

@pzelasko
Copy link
Copy Markdown
Collaborator

Thanks!

@pzelasko pzelasko merged commit 6d77963 into NVIDIA-NeMo:main Mar 19, 2026
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants