Skip to content

Add Zenodo download URLs to broken links false positives#15488

Merged
chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
XuesongYang:xueyang/pr-fix-broken-links
Mar 12, 2026
Merged

Add Zenodo download URLs to broken links false positives#15488
chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
XuesongYang:xueyang/pr-fix-broken-links

Conversation

@XuesongYang
Copy link
Copy Markdown
Collaborator

Zenodo blocks automated link checkers with 403, causing CI failures for valid Thorsten Voice dataset download links in tts/datasets.rst.

@XuesongYang XuesongYang requested review from chtruong814 and Copilot and removed request for Copilot March 12, 2026 06:17
@github-actions github-actions Bot added the TTS label Mar 12, 2026
Zenodo blocks automated link checkers with 403, causing CI failures
for valid Thorsten Voice dataset download links in tts/datasets.rst.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 12, 2026 06:19
@XuesongYang XuesongYang force-pushed the xueyang/pr-fix-broken-links branch from 9eb2cc3 to 85835a3 Compare March 12, 2026 06:19
@github-actions github-actions Bot removed the TTS label Mar 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent documentation link-check CI failures caused by Zenodo returning 403 responses to automated checkers for valid Thorsten Voice dataset download URLs referenced in the TTS datasets docs.

Changes:

  • Added Zenodo Thorsten Voice download URLs to the docs broken-link false positives list.
  • Introduced a new file under docs/source/tts/ containing a numeric string (appears unintended).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

File Description
docs/source/broken_links_false_positives.json Adds two Zenodo dataset download URLs as known false positives for link checking.
docs/source/tts/Untitled New single-line file with a numeric value; likely an accidental artifact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +76 to +77
{ "filename": "tts/datasets.rst", "lineno": 1, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1" }
{ "filename": "tts/datasets.rst", "lineno": 1, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1" }
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lineno values for these Zenodo URLs are set to 1, but the links in docs/source/tts/datasets.rst are currently at lines ~140 and ~145. Please update lineno to the correct source line numbers (or confirm the consumer of this file matches only on uri), so future debugging and any line-based matching doesn’t break.

Suggested change
{ "filename": "tts/datasets.rst", "lineno": 1, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1" }
{ "filename": "tts/datasets.rst", "lineno": 1, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1" }
{ "filename": "tts/datasets.rst", "lineno": 140, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/7265581/files/ThorstenVoice-Dataset_2022.10.zip?download=1" }
{ "filename": "tts/datasets.rst", "lineno": 145, "status": "broken", "code": 0, "uri": "https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1", "info": "403 Client Error: Forbidden for url: https://zenodo.org/record/5525342/files/thorsten-neutral_v03.tgz?download=1" }

Copilot uses AI. Check for mistakes.
@chtruong814 chtruong814 merged commit bb205c2 into NVIDIA-NeMo:main Mar 12, 2026
42 checks passed
@XuesongYang XuesongYang deleted the xueyang/pr-fix-broken-links branch March 12, 2026 15:52
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
…#15488)

Zenodo blocks automated link checkers with 403, causing CI failures
for valid Thorsten Voice dataset download links in tts/datasets.rst.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants