Skip to content

EoU classifier: better handling of sampling rate#15496

Closed
rfejgin wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
rfejgin:magpietts_eou_sample_rate
Closed

EoU classifier: better handling of sampling rate#15496
rfejgin wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
rfejgin:magpietts_eou_sample_rate

Conversation

@rfejgin
Copy link
Copy Markdown
Collaborator

@rfejgin rfejgin commented Mar 13, 2026

When accepting NumPy arrays as input, its sampling rate was not defined and it was ambiguous as to whether it's the caller's responsibility to resample it to 16 kHz (for audio file inputs, the classifier was doing the resampling).

Clarify this by requiring a sampling rate parameter when providing NumPy inputs. We then resample internally to 16 kHz if needed. So now the inputs can be any sampling rate in both cases - WAV file input or NumPy input.

Also:

  • removed the sampling rate argument from the classifier's constructor as it is internally always 16 kHz.
  • added associated tests

rfejgin added 2 commits March 12, 2026 17:49
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant