[MagpieTTS][TTS] ja longform fix and StrEnum import fix#15499
Merged
Conversation
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>
Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>
Contributor
|
[🤖]: Hi @subhankar-ghosh 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
blisc
requested changes
Mar 16, 2026
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>
Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>
Added compatibility for StrEnum in Python versions < 3.11. Signed-off-by: Subhankar Ghosh <subhankarg@nvidia.com>
Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>
blisc
approved these changes
Mar 16, 2026
rfejgin
approved these changes
Mar 16, 2026
Collaborator
rfejgin
left a comment
There was a problem hiding this comment.
Looks good but please see comment
| for offset, weight in enumerate(prior_weights[:5]): | ||
| idx = current_starting_point + offset | ||
| if idx < max_text_len: | ||
| _attn_prior[_idx, :, idx] = weight |
Collaborator
There was a problem hiding this comment.
I'd suggest to name at least one of _idx and idx differently to help distinguish their meaning more easily
Contributor
|
[🤖]: Hi @subhankar-ghosh 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Mar 19, 2026
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
The _initialize_chunked_attn_prior function writes attention prior weights to 5 consecutive text token positions starting at
current_starting_point. The offsets 0–4 are hardcoded with no bounds check. If the chunk has fewer than current_starting_point + 5 tokens, index + 4 goes out of bounds.
This surfaces for Japanese longform because:
StrEnum was added to Python's standard library enum module in Python 3.11. On Python 3.10, from enum import StrEnum raises an
ImportError at import time, which means the entire eou_classifier module fails to load — crashing any environment running
Python 3.10.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information