[ci, build] fix: unblock testpypi publish — drop direct git URL dep, bump CI template to v0.94.1#15659
Merged
Conversation
…ce twine errors Bumps the reusable workflow ref from v0.22.3 to v0.94.1, which adds `--verbose --skip-existing` to the `twine upload` invocation. The PyPi wheel publish job has been failing on every push to main since 2026-04-23 with a bare `HTTPError: 400 Bad Request from https://test.pypi.org/legacy/` and no body, because v0.22.3 does not pass `--verbose` to twine. Bumping unblocks diagnosis. Also adds a `workflow_dispatch:` trigger so this workflow can be fired manually for testing without merging to main. Signed-off-by: oliver könig <okoenig@nvidia.com>
PyPI/TestPyPI rejects projects whose metadata declares any direct URL or
VCS dependency (PEP 508 `pkg @ <url>` form). The line
nemo_automodel @ git+https://github.com/NVIDIA-NeMo/Automodel.git@<sha>
introduced in #15447 caused every wheel publish since 2026-04-23 to fail
with `400 Can't have direct dependency: nemo_automodel @ ... ; extra ==
"speechlm2-only"`. Removing the line so the wheel can be uploaded.
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
changed the title
chtruong814
reviewed
May 4, 2026
| @@ -1,2 +1 @@ | |||
| nemo_automodel @ git+https://github.com/NVIDIA-NeMo/Automodel.git@9eccbb6102a260efd7cbdffa890fc57b94f94528 # version with relaxed pytorch constraints | |||
Collaborator
There was a problem hiding this comment.
We should leave automodel here? or pin to a specific version that included this commit?
…ead of wheel metadata PyPI/TestPyPI rejects wheels whose metadata declares a direct git URL dependency (PEP 508 `pkg @ <url>` form) with `400 Can't have direct dependency`. The previous fix dropped the `nemo_automodel @ git+...` line from `requirements_speechlm2.txt` entirely, but speechlm2 still needs it at runtime. Track the pinned commit in `requirements/manifest.json` alongside the other VCS deps and have `docker/common/install_dep.sh extra` (invoked by `docker/Dockerfile.ci`) override-install it. The wheel metadata stays clean, the GitHub CI image still has the right `nemo_automodel` commit, and `requirements_speechlm2.txt` documents where the dep lives. Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
approved these changes
May 4, 2026
Contributor
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
ko3n1g
added a commit
that referenced
this pull request
May 4, 2026
…5662) Restore nemo_automodel as a plain PyPI dependency in requirements/requirements_speechlm2.txt. It was unintentionally dropped in #15659 along with the direct git URL form that was blocking PyPI/TestPyPI publish (`400 Can't have direct dependency`). The plain name avoids that failure mode while keeping the runtime dep declared where users expect it. Signed-off-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
The TestPyPI publish job has failed on every push to
mainsince 2026-04-23 with400 Bad Requestfromhttps://test.pypi.org/legacy/.Cause. PyPI/TestPyPI rejects any project whose metadata declares a direct URL/VCS dependency (PEP 508
pkg @ <url>form).requirements/requirements_speechlm2.txt(introduced 2026-04-23 in #15447) contained:With
--verboseenabled, TestPyPI surfaces the actual response:Fix.
nemo_automodelas a tracked dependency, just not in the wheel metadata. Remove thenemo_automodel @ git+...line fromrequirements/requirements_speechlm2.txt(which feedsextras_require['speechlm2-only']viasetup.py, and is therefore baked into wheel metadata) and instead pin the commit inrequirements/manifest.jsonalongside the other VCS deps.docker/common/install_dep.sh extra(invoked bydocker/Dockerfile.ci, which is what GitHub CI builds) reads the pinned ref frommanifest.jsonand addsnemo_automodel @ git+<repo>@<ref>to itspip installstep. Net effect: the published wheel has clean metadata, but every CI image still gets the exact samenemo_automodelcommit._build_test_publish_wheelfromv0.22.3→v0.94.1(the newer reusable workflow already passes--verbose --skip-existingtotwine upload). Addworkflow_dispatch:so the workflow can be triggered for testing without waiting on a push tomain.Layout after this PR:
requirements/manifest.json→vcs-dependencies.nemo_automodelrepo+ref(single source of truth)docker/common/install_dep.sh→extra()nemo_automodel @ git+<repo>@<ref>requirements/requirements_speechlm2.txtflashoptim+ a comment pointing to the manifest/install_dep entryVerification. Re-triggered on this branch via
workflow_dispatch; all jobs green.https://test.pypi.org/simple/nemo-toolkit/now returns200(was404).