Skip to content

[build] fix: restore nemo_automodel in requirements_speechlm2.txt#15662

Merged
ko3n1g merged 1 commit into
mainfrom
ko3n1g/build/restore-nemo-automodel-speechlm2
May 4, 2026
Merged

[build] fix: restore nemo_automodel in requirements_speechlm2.txt#15662
ko3n1g merged 1 commit into
mainfrom
ko3n1g/build/restore-nemo-automodel-speechlm2

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented May 4, 2026

Claude summary

What does this PR do?

Restores nemo_automodel in requirements/requirements_speechlm2.txt after it was unintentionally dropped in #15659.

Why

#15659 removed the line

nemo_automodel @ git+https://github.com/NVIDIA-NeMo/Automodel.git@<sha>

to unblock PyPI/TestPyPI wheel publishing, which rejects direct URL / VCS deps with 400 Can't have direct dependency. Removing the nemo_automodel entry entirely was an accident — the dep is still required at runtime for the speechlm2 extra and should be declared in the requirements file users look at.

Fix

Re-add nemo_automodel as a plain PyPI dep (no @ git+... URL), so the wheel publish keeps working while the dependency is once again visible in the requirements file:

+nemo_automodel
 flashoptim

Restore nemo_automodel as a plain PyPI dependency in
requirements/requirements_speechlm2.txt. It was unintentionally dropped
in #15659 along with the direct git URL form that was blocking
PyPI/TestPyPI publish (`400 Can't have direct dependency`). The plain
name avoids that failure mode while keeping the runtime dep declared
where users expect it.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner May 4, 2026 17:39
@ko3n1g ko3n1g merged commit 53557ad into main May 4, 2026
47 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/restore-nemo-automodel-speechlm2 branch May 4, 2026 17:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants