Skip to content

ci: Major refactor of release-workflows#15668

Merged
ko3n1g merged 22 commits into
NVIDIA-NeMo:mainfrom
ko3n1g:ko3n1g/refactor/validate-only-release
May 11, 2026
Merged

ci: Major refactor of release-workflows#15668
ko3n1g merged 22 commits into
NVIDIA-NeMo:mainfrom
ko3n1g:ko3n1g/refactor/validate-only-release

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented May 6, 2026

Why

See the design discussion in NVIDIA-NeMo/FW-CI-templates#466.

What

  • Delete .github/workflows/build-test-publish-wheel.yml.
  • Rewrite .github/workflows/release.yml as the single caller for both push and workflow_dispatch.

Test plan

Rollout

  1. Land FW-CI-templates#466.
  2. Cut FW-CI-templates v1.0.0.
  3. Bump the SHA pin in this PR → tag.

Adopts the FW-CI-templates v1.0.0 pattern (NVIDIA-NeMo/FW-CI-templates#466):
- single release.yml caller for both push (validate-only) and
  workflow_dispatch (real release / dry-run)
- one pin governs PR rehearsal and shipped release
- drops PAT/SSH_KEY/SSH_PWD secrets (App-only auth)
- bumps FW-CI pin from v0.80.3 to current SHA

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 6, 2026

/ok to test e84d9bc

…level)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 6, 2026

/ok to test ef8fe19

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 6, 2026

/ok to test 0af788a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 6, 2026

/ok to test 654c88e

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 6cf95b9

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 53f93ba

3 similar comments
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 53f93ba

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 53f93ba

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 53f93ba

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

ko3n1g added 2 commits May 7, 2026 20:14
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Comment thread .github/workflows/release.yml Outdated
docs-target-path: nemo
docs-directory: docs/source
docs-requirements-file: requirements/requirements_docs.txt
docs-fail-on-warning: false
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we setting docs-fail-on-warning false here?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

ko3n1g added 3 commits May 8, 2026 08:20
Signed-off-by: oliver könig <okoenig@nvidia.com>
…!failure)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g added 2 commits May 9, 2026 09:39
This reverts commit 1a75e0b.

_release_library.yml@v1.0.0 does not expose sync-all/no-extras inputs.
Forwarding is added in NVIDIA-NeMo/FW-CI-templates#473; once that lands
and gets tagged, bump the pin here and re-add the inputs as
docs-sync-all / docs-no-extras.

Signed-off-by: oliver könig <okoenig@nvidia.com>
…extras

v1.2.0 of NVIDIA-NeMo/FW-CI-templates#473 forwards docs-no-extras (and the
existing docs-sync-all) to _build_docs.yml, so the release path can now
match build-docs.yml (sync all groups, skip the cu12 extra).

Signed-off-by: oliver könig <okoenig@nvidia.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants