Skip to content

Conversation

Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Sep 29, 2025

Summary by CodeRabbit

  • Tests
    • Updated disaggregated integration tests to use a provided config path and separate prompt argument, consolidating CLI flags into a single invocation. Argument order changed without affecting behavior.
    • Enhanced Triton LLM integration tests to accept a tiny Llama model path and apply it to the test configuration, improving portability and setup consistency.
    • No functional changes to end-user features; updates focus on test reliability and clearer, parameterized test setups.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

📝 Walkthrough

Walkthrough

Updates two integration tests: one switches the client invocation to use a passed config file and adjusts CLI argument ordering; the other adds a parameter for a tiny Llama model path and injects it into the Triton LLM test model configuration.

Changes

Cohort / File(s) Summary
Disaggregated test CLI invocation
tests/integration/defs/disaggregated/test_disaggregated.py
run_disaggregated_test now uses the provided config_file instead of a hardcoded path; passes prompt via -p; consolidates CLI flags into one line with adjusted argument order, preserving options.
Triton LLM test model path injection
tests/integration/defs/triton_server/test_triton_llm.py
test_llmapi_backend signature gains tiny_llama_model_root; test sets model_config["model"] to this path before writing config; no other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description consists solely of the unfilled repository template with placeholder comments and lacks a concrete title line, a summary of the issue and solution in the Description section, and any entries under Test Coverage, making it impossible to understand the intent or verify test coverage. Please fill in the template by providing a compliant PR title (including ticket and type), a concise Description explaining the problem and the implemented fix, and a Test Coverage section listing the relevant tests that guard these changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[https://nvbugs/5547414][fix] avoid downloading Tiny llama from HF" clearly describes the main objective of the changes. The changeset modifies two test files to pass a tiny_llama_model_root parameter that enables tests to use a local model path instead of downloading from Hugging Face. The title accurately captures the primary intent (avoiding HF downloads for Tiny Llama) and follows the repository's required format with a valid NVBugs ticket and type tag. While it doesn't mention the specific test files modified, this level of detail is not expected in a title.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tabrizian
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20291 [ run ] triggered by Bot

@Tabrizian Tabrizian requested a review from chzblych September 29, 2025 21:53
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20291 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15302 completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20304 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20304 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15312 completed with status: 'FAILURE'

@Tabrizian
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20394 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20394 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15388 completed with status: 'SUCCESS'

@Tabrizian Tabrizian merged commit c510b67 into NVIDIA:main Sep 30, 2025
7 of 9 checks passed
@Tabrizian Tabrizian deleted the user/imant/disaggTestFix branch September 30, 2025 17:48
faradawn pushed a commit to faradawn/TensorRT-LLM that referenced this pull request Oct 2, 2025
…VIDIA#8071)

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
Signed-off-by: Faradawn Yang <faradawny@gmail.com>
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Oct 3, 2025
…VIDIA#8071)

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants