[#7588][fix] fixed the kv cache size parsing in test_perf.py AD backend

[MrGeva]

Summary by CodeRabbit

• New Features
  • None
• Bug Fixes
  • Improved robustness of performance metrics reporting by correctly detecting KV cache size across varied log messages.
  • Ensures reliable numeric extraction even when multiple capture groups are present, preventing missed or incorrect values.
• Tests
  • Updated integration performance tests to handle new and legacy KV cache size log formats, reducing false negatives and improving test stability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[MrGeva]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Extended KV cache size parsing in perf test: broadened regex to match two log formats and updated value extraction to handle multiple capture groups by selecting the first non-None group and converting to float. No API or signature changes.

Changes

Cohort / File(s)	Summary
Perf metrics parsing tests/integration/defs/perf/test_perf.py	Broadened KV cache size regex to match original and "Final ... after resize" messages; replaced single-group extraction with first-non-None group selection and float conversion; improved robustness for multi-group matches.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description remains the unmodified template and does not include any actual summary, explanation of the issue and solution, or test coverage details, leaving all key sections empty and incomplete.	Please fill in the summary, Description, and Test Coverage sections with concise details of the changes and add relevant test references to complete the PR description.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly follows the repository’s template by including the GitHub issue reference and type tag and concisely describes the main change of fixing the KV cache size parsing in the specified test file for the AD backend.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 948b8b9 and 6f7ffb5.

📒 Files selected for processing (1)

• tests/integration/defs/perf/test_perf.py (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tests/integration/defs/perf/test_perf.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tests/integration/defs/perf/test_perf.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tests/integration/defs/perf/test_perf.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (2)

tests/integration/defs/perf/test_perf.py (2)

277-278: LGTM! Regex pattern correctly handles multiple log formats.

The updated regex properly matches both the original KV cache allocation message and the new resize message format. Using a non-capturing group with alternation ensures both patterns are recognized while maintaining readability.

---

1612-1622: LGTM! Value extraction correctly handles multiple capture groups.

The updated logic properly iterates through all capture groups to find the first non-None match, which is essential for the alternation pattern in the KV_CACHE_SIZE regex. The float conversion is correctly placed after finding a valid value.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #20350 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20350 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15351 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20368 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20368 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15364 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20388 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20388 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15382 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20407 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20407 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15398 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20440 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20440 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User MrGeva is not in the prioritized list. L0 testing cannot be triggered.

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20450 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20450 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15417 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20458 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20458 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15424 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20516 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20516 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15475 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #20546 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20546 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15503 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.