Skip to content

Conversation

@ZhanruiSunCh
Copy link
Collaborator

@ZhanruiSunCh ZhanruiSunCh commented Oct 10, 2025

Summary by CodeRabbit

  • Refactor

    • Simplified Jenkins Kubernetes pod scheduling by removing hardware-specific hostname exclusions.
    • Pods now consistently target the generic core node selector, reducing conditional logic and variability.
  • Chores

    • Streamlined configuration for more predictable scheduling behavior across environments.
    • Potentially expands eligible nodes for jobs that previously avoided certain hosts, improving utilization.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --gpu-type "GH200"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Removes GH200-specific hostname affinity logic from createKubernetesPodConfig in jenkins/L0_Test.groovy. Deletes conditional hostnameNotIn construction and associated variable. Pod YAML now consistently applies a generic "core" node selector without hostname-based exclusions.

Changes

Cohort / File(s) Summary
Jenkins pod config
jenkins/L0_Test.groovy
Removed GH200 hostnameNotIn affinity and related conditional code; deleted hostnameMatch construction; simplified pod YAML to always include the "core" node selector; eliminated per-type hostname exclusion branch.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant P as Pipeline
  participant F as createKubernetesPodConfig
  participant Y as PodSpec Builder

  P->>F: Request pod config (type)
  F->>Y: Build pod YAML
  Note over Y: Old: Conditional hostname exclusion when type == "gh200"
  Note over Y: New: Always apply generic "core" selector
  Y-->>F: Pod YAML
  F-->>P: Return config
Loading
sequenceDiagram
  autonumber
  participant P as Pipeline
  participant F as createKubernetesPodConfig
  participant K as Affinity/Selector Logic

  rect rgb(245,245,255)
  note right of F: Old flow
  P->>F: type = "gh200" or other
  alt type == "gh200"
    F->>K: Build hostnameNotIn affinity
    K-->>F: Affinity block
  else other types
    Note over F: No hostname exclusion
  end
  F-->>P: Pod YAML (selector + optional affinity)
  end

  rect rgb(245,255,245)
  note right of F: New flow
  P->>F: type (any)
  F->>K: Apply fixed "core" node selector
  Note over K: No hostname-based affinity
  F-->>P: Pod YAML (core selector only)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description consists solely of the template boilerplate without any actual title, summary of the change, explanation of the issue and solution, test coverage details, or completed checklist items, so it fails to meet the repository’s required structure and content. Please add a proper PR title following the “[JIRA ticket/ID][type] Summary” format, fill in the Description section with a concise explanation of what was changed and why, list relevant tests under Test Coverage, and complete the PR Checklist items before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title correctly follows the “[None][infra]” format and succinctly summarizes the removal of GH200-specific code, aligning with the change to eliminate GH200 hostname affinity logic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZhanruiSunCh ZhanruiSunCh requested a review from chzblych October 10, 2025 10:02
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21023 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21023 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15896 (Partly Tested) completed with status: 'SUCCESS'

@chzblych
Copy link
Collaborator

/bot skip --comment "Partial testing is sufficient"

@chzblych chzblych enabled auto-merge (squash) October 12, 2025 03:14
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21085 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21085 [ skip ] completed with state SUCCESS
Skipping testing for commit 6c60f51

@chzblych chzblych merged commit 5798a12 into NVIDIA:main Oct 12, 2025
7 of 9 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants