[TRTLLM-8831][feat] Enable early exit with overlap scheduler #8587
Conversation
|
/bot run |
|
PR_Github #22195 [ run ] triggered by Bot. Commit: |
Funatiq
changed the title
|
PR_Github #22195 [ run ] completed with state |
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
2ad7022 to
e5ab4a8
Compare
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #22295 [ run ] triggered by Bot. Commit: |
|
PR_Github #22295 [ run ] completed with state |
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
e5ab4a8 to
3d197cb
Compare
|
/bot run |
|
PR_Github #22648 [ run ] triggered by Bot. Commit: |
|
PR_Github #22648 [ run ] completed with state |
|
/bot run |
|
PR_Github #22657 [ run ] triggered by Bot. Commit: |
|
PR_Github #22657 [ run ] completed with state |
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
3d197cb to
10a1cf0
Compare
|
/bot run |
|
PR_Github #22663 [ run ] triggered by Bot. Commit: |
|
PR_Github #22663 [ run ] completed with state |
|
/bot run |
|
PR_Github #22675 [ run ] triggered by Bot. Commit: |
|
PR_Github #22675 [ run ] completed with state |
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
b788274 to
1492f63
Compare
|
/bot run |
|
PR_Github #22756 [ run ] triggered by Bot. Commit: |
|
PR_Github #22756 [ run ] completed with state |
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
1492f63 to
73a01b0
Compare
|
/bot run |
|
PR_Github #22769 [ run ] triggered by Bot. Commit: |
|
/bot run --disable-fail-fast |
|
PR_Github #24586 [ run ] triggered by Bot. Commit: |
|
PR_Github #24586 [ run ] completed with state |
- Update MicroBatchScheduler bindings to skip scheduling after GENERATION_TO_COMPLETE state. - Update PyExecutor to set GENERATION_TO_COMPLETE state for requests that will complete next iteration. - Fix _executor_loop_overlap to finish previous batch if current batch is empty. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
…for overlap scheduler Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
- Add loop over sequences in test_generate_with_return_logits and test_generate_async_with_return_logits. - Add assertion on sequence length in test_generate_with_return_logits and test_generate_async_with_return_logits. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
- Reduce call_counts when using the overlap scheduler. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
- Updated the test to utilize a context manager for the LLM instance, improving resource management. - Maintained existing assertions to validate performance metrics. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
- Moved iter_counter in PyExecutor to ensure consistency in tracking iterations. - This allows tracking of iteration where scheduled requests are empty. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Funatiq
force-pushed
the
dev/feat/overlap_early_exit
branch
from
0fbdf51 to
6348945
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #24677 [ run ] triggered by Bot. Commit: |
|
PR_Github #24677 [ run ] completed with state |
|
/bot run |
|
PR_Github #24693 [ run ] triggered by Bot. Commit: |
|
PR_Github #24693 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #24750 [ run ] triggered by Bot. Commit: |
|
PR_Github #24750 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #24763 [ run ] triggered by Bot. Commit: |
|
PR_Github #24763 [ run ] completed with state |
6 participants
Summary by CodeRabbit
New Features
willCompleteNextIterationmethod for improved request state querying.Bug Fixes
Tests
Description
Usually with overlap scheduler we schedule one iteration ahead. The idea here is that when a request reaches its
max_tokenswe can avoid the last extra iteration because we know that the request will finish. This also leads to a final iteration of the execution loop where no requests are scheduled (scheduled_batchis empty) but we still have to process the results from the previous iteration (previous_batchexists).PyExecutorto setGENERATION_TO_COMPLETEstate for requests that will complete next iteration.MicroBatchSchedulerbindings to skip scheduling afterGENERATION_TO_COMPLETEstate._executor_loop_overlapto finish previous batch if current batch is empty.ModelEnginetoPyExecutorto account for empty batches.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.