Skip to content

Conversation

@karljang
Copy link
Collaborator

@karljang karljang commented Oct 30, 2025

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@karljang
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23153 [ run ] triggered by Bot. Commit: 72752b4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23153 [ run ] completed with state FAILURE. Commit: 72752b4
/LLM/main/L0_MergeRequest_PR pipeline #17461 completed with status: 'FAILURE'

@karljang karljang marked this pull request as draft October 31, 2025 20:20
@karljang
Copy link
Collaborator Author

Hi @atrifex ,
I just realized that the scope of this task goes beyond simply updating statements. Could you please take a look at the error when you get a chance?

[2025-10-31T07:24:36.482Z] 2025/10/31 07:24:36 warning tensorrt_llm/kernels/cutlass_kernels/fp8_rowwise_gemm/fp8_rowwise_gemm_template.h: parse failed
[2025-10-31T07:24:36.482Z] 2025/10/31 07:24:36 warning tensorrt_llm/kernels/cutlass_kernels/python/generate_kernels.py: license not exist
[2025-10-31T07:24:36.482Z] 2025/10/31 07:24:36 error tensorrt_llm/kernels/decoderMaskedMultiheadAttention/decoderXQAImplJIT/nvrtcWrapper/src/nvrtcWrapper.cpp: license not match, expected: nvidia, got: apache

Also, there are quite a few logs like below, but it's possible that they're just warnings, but I'm not entirely sure.

[2025-10-31T07:24:36.481Z] 2025/10/31 07:24:36 warning include/tensorrt_llm/deep_gemm/tma_utils.cuh: parse failed
[2025-10-31T07:24:36.481Z] FAILED header of include/tensorrt_llm/deep_gemm/utils.cuh:
[2025-10-31T07:24:36.481Z] SPDX-FileCopyrightText: Copyright (c) 2025 DeepSeek
[2025-10-31T07:24:36.481Z] SPDX-License-Identifier: MIT
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] Licensed under the MIT License.
[2025-10-31T07:24:36.481Z] You may obtain a copy of the License at
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] https://opensource.org/licenses/MIT
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
[2025-10-31T07:24:36.481Z] SPDX-License-Identifier: Apache-2.0
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] Licensed under the Apache License, Version 2.0 (the "License");
[2025-10-31T07:24:36.481Z] you may not use this file except in compliance with the License.
[2025-10-31T07:24:36.481Z] You may obtain a copy of the License at
[2025-10-31T07:24:36.481Z] 
[2025-10-31T07:24:36.481Z] http://www.apache.org/licenses/LICENSE-2.0

Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
@karljang
Copy link
Collaborator Author

@atrifex ,
I have rebased the branch to rerun the tests to reproduce the previous error, but IIRC, the errors were related to settings in jenkins/license_cpp.json

@karljang
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24945 [ run ] triggered by Bot. Commit: cca1c74

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24945 [ run ] completed with state FAILURE. Commit: cca1c74
/LLM/main/L0_MergeRequest_PR pipeline #18843 completed with status: 'FAILURE'

Removed the NVIDIA license rules

Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
@karljang
Copy link
Collaborator Author

@atrifex ,
Just a heads-up: commit 74fe723 removed all NVIDIA license rules.
Wanted to highlight it in case it slipped through unnoticed.

@karljang
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25089 [ run ] triggered by Bot. Commit: 74fe723

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25089 [ run ] completed with state FAILURE. Commit: 74fe723
/LLM/main/L0_MergeRequest_PR pipeline #18965 completed with status: 'FAILURE'

@tburt-nv
Copy link
Collaborator

/bot skip --comment "only needs release check"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25095 [ skip ] triggered by Bot. Commit: 74fe723

@karljang karljang marked this pull request as ready for review November 19, 2025 21:33
@karljang karljang requested review from a team as code owners November 19, 2025 21:33
@karljang karljang requested review from a team as code owners November 19, 2025 21:33
@tensorrt-cicd
Copy link
Collaborator

PR_Github #25095 [ skip ] completed with state SUCCESS. Commit: 74fe723
Skipping testing for commit 74fe723

Copy link
Collaborator

@thorjohnsen thorjohnsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karljang karljang merged commit 41e5870 into NVIDIA:main Nov 19, 2025
5 checks passed
@karljang karljang deleted the update-license branch November 19, 2025 23:08
yzh119 pushed a commit to flashinfer-ai/flashinfer that referenced this pull request Nov 20, 2025
<!-- .github/pull_request_template.md -->

## 📌 Description

Update xqa license based on
NVIDIA/TensorRT-LLM#8807
<!-- What does this PR do? Briefly describe the changes and why they’re
needed. -->

## 🔍 Related Issues
#1977
<!-- Link any related issues here -->

## 🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull
request, please make sure the following items are complete.

### ✅ Pre-commit Checks

- [ ] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [ ] I have installed the hooks with `pre-commit install`.
- [ ] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.

> If you are unsure about how to set up `pre-commit`, see [the
pre-commit documentation](https://pre-commit.com/).

## 🧪 Tests

- [ ] Tests have been added or updated as needed.
- [ ] All tests are passing (`unittest`, etc.).

## Reviewer Notes

<!-- Optional: anything you'd like reviewers to focus on, concerns, etc.
-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated project licensing to Apache License 2.0 with extended
copyright years through 2025.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Qidi Sang <200703406+qsang-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants