[https://nvbugs/5616189][fix] Make more cases use local cached models #8935
Conversation
📝 WalkthroughWalkthroughThe PR consolidates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
examples/llm-api/quickstart_example.py(1 hunks)examples/models/core/bert/utils.py(1 hunks)examples/utils.py(1 hunks)tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py(3 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
examples/llm-api/quickstart_example.pyexamples/utils.pyexamples/models/core/bert/utils.pytests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
examples/llm-api/quickstart_example.pyexamples/utils.pyexamples/models/core/bert/utils.pytests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
examples/llm-api/quickstart_example.pyexamples/utils.pyexamples/models/core/bert/utils.pytests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
🧠 Learnings (3)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
examples/llm-api/quickstart_example.pytests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
Repo: NVIDIA/TensorRT-LLM PR: 6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
Applied to files:
tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
Applied to files:
tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
🧬 Code graph analysis (4)
examples/llm-api/quickstart_example.py (1)
examples/utils.py (1)
llm_models_root(588-601)
examples/utils.py (1)
tests/integration/defs/conftest.py (1)
llm_models_root(80-94)
examples/models/core/bert/utils.py (1)
examples/utils.py (1)
llm_models_root(588-601)
tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py (1)
examples/utils.py (1)
llm_models_root(588-601)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (4)
examples/llm-api/quickstart_example.py (1)
1-1: LGTM!The import follows the coding guideline to maintain module namespace.
tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py (2)
29-31: Correct f-string usage, but verify None handling.The f-string syntax is correct here. However, since
llm_models_root()returns a value that could conceptually be None (based on the examples/utils.py implementation), ensure the test environment guarantees a valid path exists, or add appropriate error handling.Consider adding an assertion at the test module level if not already present:
def setup_module(): assert llm_models_root() is not None, "LLM_MODELS_ROOT must be configured for tests"
4-4: Fix missing f-string prefix on line 17.Line 17 uses a plain string
"{llm_models_root()}/TinyLlama-1.1B-Chat-v1.0"which won't interpolate the function call. Add thefprefix:f"{llm_models_root()}/TinyLlama-1.1B-Chat-v1.0"to match the correct usage on line 30.The import from
defs.confteston line 4 is correct and consistent with this file's test configuration.Likely an incorrect or invalid review comment.
examples/models/core/bert/utils.py (1)
12-12: LGTM! Good consolidation to eliminate duplication.The import correctly replaces the local implementation with the centralized utility function, following the DRY principle. The usage at line 19 with
check=Trueensures proper error messaging if the path doesn't exist.
tests/unittest/_torch/ray_orchestrator/multi_gpu/test_executor.py
Outdated
Show resolved
Hide resolved
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1" --extra-stage "A10-PackageSanityCheck-PY310-UB2204-CU12" --disable-fail-fast |
|
PR_Github #23588 [ run ] triggered by Bot. Commit: |
HuiGao-NV
force-pushed
the
use_local_models
branch
from
2d854c5 to
ee6542f
Compare
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1" |
|
PR_Github #23596 [ run ] triggered by Bot. Commit: |
|
PR_Github #23588 [ run ] completed with state |
HuiGao-NV
changed the title
|
PR_Github #23596 [ run ] completed with state |
HuiGao-NV
force-pushed
the
use_local_models
branch
from
ee6542f to
46f3c33
Compare
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1" |
|
PR_Github #23644 [ run ] triggered by Bot. Commit: |
|
PR_Github #23644 [ run ] completed with state |
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1" |
|
PR_Github #23660 [ run ] triggered by Bot. Commit: |
|
PR_Github #23660 [ run ] completed with state |
HuiGao-NV
force-pushed
the
use_local_models
branch
from
8903508 to
b6d4876
Compare
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1" |
|
PR_Github #23687 [ run ] triggered by Bot. Commit: |
|
PR_Github #23687 [ run ] completed with state |
|
/bot run --post-merge |
|
PR_Github #23703 [ run ] triggered by Bot. Commit: |
|
/bot run --disable-multi-gpu-test --gpu-type "A30,A10" |
|
PR_Github #23706 [ run ] triggered by Bot. Commit: |
HuiGao-NV
force-pushed
the
use_local_models
branch
from
3881a66 to
6b1423b
Compare
|
PR_Github #23884 [ run ] completed with state |
|
/bot run --disable-multi-gpu-test --gpu-type "A10" --disable-fail-fast |
|
PR_Github #23896 [ run ] triggered by Bot. Commit: |
|
PR_Github #23896 [ run ] completed with state |
Signed-off-by: Hui Gao <huig@nvidia.com>
HuiGao-NV
force-pushed
the
use_local_models
branch
from
6b1423b to
0977926
Compare
|
/bot run --disable-multi-gpu-test --gpu-type "A10" --disable-fail-fast |
HuiGao-NV
changed the title
HuiGao-NV
changed the title
|
PR_Github #24116 [ run ] triggered by Bot. Commit: |
Signed-off-by: Hui Gao <huig@nvidia.com>
|
PR_Github #24116 [ run ] completed with state |
|
/bot run --disable-multi-gpu-test --gpu-type "A10" --disable-fail-fast |
|
PR_Github #24133 [ run ] triggered by Bot. Commit: |
|
PR_Github #24133 [ run ] completed with state |
|
/bot skip --comment "Impacted cases have been tested in previous CI" |
|
PR_Github #24172 [ skip ] triggered by Bot. Commit: |
|
PR_Github #24172 [ skip ] completed with state |
…NVIDIA#8935) Signed-off-by: Hui Gao <huig@nvidia.com>
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.