Skip to content

[https://nvbugs/5633340][fix] kill processes properly after test #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

[https://nvbugs/5633340][fix] kill processes properly after test #8970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6946f3
kill processes properly after test
reasonsolo Nov 6, 2025
3056d29
Merge branch 'main' into bug5633340
reasonsolo Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/integration/defs/disaggregated/test_auto_scaling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

from tensorrt_llm.logger import logger

TEST_PORT = 18000
TEST_PORT = 8000
HEARTBEAT_INTERVAL = 1
INACTIVE_TIMEOUT = 2

Expand Down Expand Up @@ -192,13 +192,13 @@ def verify_cluster_info(ready,


def terminate(*args):
try:
for arg in args:
if arg and isinstance(arg, subprocess.Popen):
arg.terminate()
for arg in args:
if arg and isinstance(arg, subprocess.Popen):
try:
arg.kill()
arg.wait(timeout=10)
except Exception:
pass
except Exception:
print(f"Failed to terminate process {arg.pid}")


def request_completion(model_name, prompt, port=TEST_PORT):
Expand Down
1 change: 0 additions & 1 deletion tests/integration/test_lists/waives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,6 @@ accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_nvfp4_multi_gpus[baselin
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=0-pp4-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False] SKIP (https://nvbugs/5503479)
test_e2e.py::test_openai_chat_harmony SKIP (https://nvbugs/5596382)
test_e2e.py::test_ptp_quickstart_multimodal_multiturn[phi4-multimodal-instruct-fp8-multimodals/Phi-4-multimodal-instruct-FP8] SKIP (https://nvbugs/5568836)
disaggregated/test_auto_scaling.py::test_disagg_server_restart[etcd-round_robin] SKIP (https://nvbugs/5633340)
accuracy/test_cli_flow.py::TestMinitron4BBase::test_fp8 SKIP (https://nvbugs/5606233)
examples/test_gpt.py::test_llm_minitron_fp8_with_pseudo_loras[4b] SKIP (https://nvbugs/5606233)
accuracy/test_llm_api_pytorch.py::TestQwen3_8B::test_bf16[multi_gpus_no_cache] SKIP (https://nvbugs/5606266)
Expand Down