[None][chore] Remove is_disaggregated param in executor request queue

[pcastonguay]

Summary by CodeRabbit

• Refactor
  • Simplified executor component initialization by removing the disaggregation parameter from PyExecutor and ExecutorRequestQueue constructors, reducing API complexity and initialization requirements.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

The is_disaggregated parameter is removed from the ExecutorRequestQueue and PyExecutor class initialization signatures, along with the corresponding field assignment in ExecutorRequestQueue and its test usages. This streamlines the initialization APIs by eliminating disaggregated-related state.

Changes

Cohort / File(s)	Summary
Core executor queue and executor implementations tensorrt_llm/_torch/pyexecutor/executor_request_queue.py, tensorrt_llm/_torch/pyexecutor/py_executor.py	Removed is_disaggregated: bool parameter from __init__ method signatures. ExecutorRequestQueue also removes its corresponding self.is_disaggregated field assignment.
Executor request queue tests tests/unittest/_torch/executor/test_executor_request_queue.py	Updated ExecutorRequestQueue instantiations to omit the is_disaggregated argument and removed related assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Homogeneous refactoring pattern: consistent parameter removal across three files
• No logic changes or control flow modifications
• Straightforward verification that all call sites are updated correctly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. While the title is present and follows the format, the Description and Test Coverage sections are empty.	Fill in the Description section explaining why is_disaggregated is being removed and the Test Coverage section listing tests that validate these changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removal of the is_disaggregated parameter from the executor request queue, which aligns directly with the changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #24053 [ run ] triggered by Bot. Commit: 42322cf

[tensorrt-cicd]

PR_Github #24053 [ run ] completed with state SUCCESS. Commit: 42322cf
/LLM/main/L0_MergeRequest_PR pipeline #18126 completed with status: 'FAILURE'

[Shunkangz]

LGTM

[Shunkangz]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #24069 [ run ] triggered by Bot. Commit: 42322cf

[tensorrt-cicd]

PR_Github #24069 [ run ] completed with state SUCCESS. Commit: 42322cf
/LLM/main/L0_MergeRequest_PR pipeline #18139 completed with status: 'FAILURE'

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #24205 [ run ] triggered by Bot. Commit: 42322cf

[tensorrt-cicd]

PR_Github #24205 [ run ] completed with state SUCCESS. Commit: 42322cf
/LLM/main/L0_MergeRequest_PR pipeline #18252 completed with status: 'FAILURE'

[pcastonguay]

/bot skip --comment "Flaky multi-GPU tests"

[tensorrt-cicd]

PR_Github #24303 [ skip ] triggered by Bot. Commit: 42322cf

[tensorrt-cicd]

PR_Github #24303 [ skip ] completed with state SUCCESS. Commit: 42322cf
Skipping testing for commit 42322cf