Skip to content

Conversation

@cheshirekow
Copy link
Collaborator

@cheshirekow cheshirekow commented Nov 12, 2025

Description

The version we are currently using has a bug when the source directory is a worktree. Among the list of files provided to hooks as "modified" is the COMMIT_EDITMSG file, which causes the "check-added-large-files" hook to always fail. The failure trace in this case is:

Traceback (most recent call last):
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/bin/check-added-large-files", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 73, in main
    return find_large_added_files(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 43, in find_large_added_files
    filter_lfs_files(filenames_filtered)
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 18, in filter_lfs_files
    check_attr = subprocess.run(
                 ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '('git', 'check-attr', 'filter', '-z', '--stdin')' returned non-zero exit status 128.

This commit upgrades pre-commit-hooks to v6.0.0, which fixes this issue.

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies to their latest versions for improved code quality and compliance checks.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

The version we are currently using has a bug when the source directory
is a worktree. Among the list of files provided to hooks as "modified"
is the COMMIT_EDITMSG file, which causes the "check-added-large-files"
hook to always fail. The failure trace in this case is:

```
Traceback (most recent call last):
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/bin/check-added-large-files", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 73, in main
    return find_large_added_files(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 43, in find_large_added_files
    filter_lfs_files(filenames_filtered)
  File "/home/redacted/.cache/pre-commit/reporscg788n/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/check_added_large_files.py", line 18, in filter_lfs_files
    check_attr = subprocess.run(
                 ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '('git', 'check-attr', 'filter', '-z', '--stdin')' returned non-zero exit status 128.
```

This commit upgrades pre-commit-hooks to v6.0.0, which fixes this issue.

Signed-off-by: Josh Bialkowski <1309820+cheshirekow@users.noreply.github.com>
@cheshirekow
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

📝 Walkthrough

Walkthrough

The .pre-commit-config.yaml file is updated to upgrade the pre-commit-hooks repository version from v4.1.0 to v6.0.0. No functional logic changes are introduced.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
\.pre-commit-config\.yaml
Upgrades pre-commit-hooks repository revision from v4.1.0 to v6.0.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that v6.0.0 is a stable release of pre-commit-hooks
  • Check release notes between v4.1.0 and v6.0.0 for any breaking changes in the hooks being used
  • Confirm that the configured hooks remain compatible with the new version

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title '[TRTLLM-9209][infra] Upgrade precommit-hooks to v6.0.0' directly and clearly summarizes the main change: upgrading a dependency to a specific version.
Description check ✅ Passed The PR description provides a clear explanation of the problem (worktree bug with COMMIT_EDITMSG), includes the relevant error trace, explains the solution, and marks the PR checklist item.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53491ff and 06c9c6c.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
.pre-commit-config.yaml (1)

1391-1392: Straightforward version upgrade to address worktree bug.

The upgrade from v4.1.0 to v6.0.0 directly resolves the documented issue with check-added-large-files failing when the source directory is a worktree and COMMIT_EDITMSG appears in the modified files list. The configuration remains otherwise unchanged, and the syntax is correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24327 [ run ] triggered by Bot. Commit: 06c9c6c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24327 [ run ] completed with state SUCCESS. Commit: 06c9c6c
/LLM/main/L0_MergeRequest_PR pipeline #18356 completed with status: 'SUCCESS'

@venkywonka venkywonka requested review from a team, Shixiaowei02, venkywonka and yuanjingx87 and removed request for a team November 12, 2025 23:50
@cheshirekow cheshirekow merged commit 3ab24df into NVIDIA:main Nov 13, 2025
8 of 9 checks passed
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Nov 19, 2025
Signed-off-by: Josh Bialkowski <1309820+cheshirekow@users.noreply.github.com>
Co-authored-by: Josh Bialkowski <1309820+cheshirekow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants