Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 13, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added test entries to the waives list for improved test management.

@xinhe-nv xinhe-nv marked this pull request as ready for review November 14, 2025 01:52
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251114_LLM_FUNCTION_TEST_1644 branch from 31e766e to f11bf6b Compare November 14, 2025 01:52
@xinhe-nv xinhe-nv enabled auto-merge (squash) November 14, 2025 01:52
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

📝 Walkthrough

Walkthrough

Two new test cases are added to the waives list and marked as SKIP: test_ptp_quickstart_multimodal (with Mistral Small parameters) and test_trtllm_multimodal_benchmark_serving. No functional changes.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Added two new SKIP entries: test_e2e.py::test_ptp_quickstart_multimodal[mistral-small-3.1-24b-instruct-Mistral-Small-3.1-24B-Instruct-2503-mixture_text_image-True] and test_e2e.py::test_trtllm_multimodal_benchmark_serving

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • kaiyux

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is extremely minimal and lacks the required information sections specified in the template (Description, Test Coverage, and PR Checklist). Expand the description to include: explanation of which tests are being waived and why they failed; relevant test coverage information; and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: adding failed test cases to the waives.txt file.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24532 [ run ] triggered by Bot. Commit: f11bf6b

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251114_LLM_FUNCTION_TEST_1644 branch from f11bf6b to 6214f53 Compare November 14, 2025 02:13
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24563 [ reuse-pipeline ] triggered by Bot. Commit: eceea5a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24532 [ run ] completed with state ABORTED. Commit: f11bf6b
LLM/main/L0_MergeRequest_PR #18517 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24563 [ reuse-pipeline ] completed with state SUCCESS. Commit: eceea5a
Can't reuse PR_Github #24532 (Partly Tested) with status: ABORTED

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24564 [ run ] triggered by Bot. Commit: eceea5a

@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Nov 14, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24564 [ run ] completed with state SUCCESS. Commit: eceea5a
/LLM/main/L0_MergeRequest_PR pipeline #18541 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251114_LLM_FUNCTION_TEST_1644 branch from a1a8e6f to d34b7f5 Compare November 14, 2025 13:55
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24597 [ reuse-pipeline ] triggered by Bot. Commit: d34b7f5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24597 [ reuse-pipeline ] completed with state SUCCESS. Commit: d34b7f5
Reusing PR_Github #24564 (Partly Tested) for commit d34b7f5

@xinhe-nv xinhe-nv merged commit 49b7e63 into NVIDIA:main Nov 14, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251114_LLM_FUNCTION_TEST_1644 branch November 14, 2025 15:47
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Nov 19, 2025
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
greg-kwasniewski1 pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 20, 2025
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants