[TRTLLM-9050][test] add llama4 disagg case to cover kv cache overflow error #9172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazydemo
force-pushed
the
add_llama4_lt
branch
from
48b7f11 to
3ef1aa0
Compare
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
crazydemo
force-pushed
the
add_llama4_lt
branch
from
3ef1aa0 to
4305920
Compare
crazydemo
force-pushed
the
add_llama4_lt
branch
from
4305920 to
73a775e
Compare
crazydemo
changed the title
Collaborator
Author
|
/bot run --skip-test |
Contributor
📝 WalkthroughWalkthroughAdds a disaggregated Llama-4 KV cache overflow configuration file and test infrastructure. Introduces a helper function to run disaggregated performance tests with MPI workers and trtllm-serve, plus a new test case with appropriate fixtures and configuration mapping. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/integration/defs/disaggregated/test_disaggregated.py (2)
1690-1785: Makerun_disaggregated_genai_perfmore robust to env/launch failuresFunction behavior is correct for the intended test, but a couple of small tweaks would make it more resilient:
envis annotated as optional but is used immediately viaenv.copy(), which would raise ifenvis everNonein a future call.- In the
finallyblock,server_proc/workers_procare used unconditionally; if process startup fails before assignment, this would raise a secondaryNameErrorand obscure the original error.You can keep the current behavior and add light guards:
def run_disaggregated_genai_perf(config_file, model_path, num_ranks, server_start_timeout=1200, input_tokens=128000, output_tokens=100, env=None, cwd=None): """Run disaggregated test with genai-perf for performance/stress testing.""" cleanup_output_files() - run_env = env.copy() + if env is None: + # Fall back to current process env if no env is provided explicitly. + env = os.environ.copy() + run_env = env.copy() @@ - finally: - server_proc.terminate() - workers_proc.terminate() - server_proc.wait() - workers_proc.wait() + finally: + # Be defensive in case startup failed before processes were created. + if 'server_proc' in locals(): + server_proc.terminate() + server_proc.wait() + if 'workers_proc' in locals(): + workers_proc.terminate() + workers_proc.wait()This keeps semantics for your current call site while avoiding fragile assumptions about
envand process creation.
1873-1908: New Llama‑4 long‑context KV cache overflow test is wired correctly; unused fixture arg is acceptable
- The symlink logic from
llm_models_root()/model_pathinto the workspace matches the relative model path used in the new YAML config (model: llama4-models/nvidia/...), sotrtllm-servesees the expected layout.get_test_config("llama4_kv_cache_overflow", ...)matches the new config_map entry and resolves to the right YAML file.- The skip markers (
skip_less_device(8),skip_less_device_memory(140000)) appropriately gate this heavy, long‑context stress test to large H100‑class setups.Static analysis notes
disaggregated_test_rootas unused, but that’s consistent with other tests here that pull in the fixture purely for setup side effects. If you want to silence ARG001 in the future without changing behavior, you could rename it to_disaggregated_test_root.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
tests/integration/defs/disaggregated/test_configs/disagg_config_llama4_kv_cache_overflow.yaml(1 hunks)tests/integration/defs/disaggregated/test_disaggregated.py(3 hunks)tests/integration/test_lists/qa/llm_function_core.txt(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Applied to files:
tests/integration/test_lists/qa/llm_function_core.txt
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Applied to files:
tests/integration/test_lists/qa/llm_function_core.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/qa/llm_function_core.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/qa/llm_function_core.txt
🧬 Code graph analysis (1)
tests/integration/defs/disaggregated/test_disaggregated.py (4)
tests/integration/defs/trt_test_alternative.py (2)
popen(199-218)check_call(250-258)tests/integration/defs/common.py (1)
wait_for_server(1141-1149)tests/integration/defs/conftest.py (4)
disaggregated_test_root(2616-2621)disaggregated_example_root(285-290)llm_venv(702-719)llm_models_root(80-94)tests/integration/defs/local_venv.py (1)
get_working_directory(43-49)
🪛 Ruff (0.14.5)
tests/integration/defs/disaggregated/test_disaggregated.py
1733-1735: Abstract raise to an inner function
(TRY301)
1733-1735: Avoid specifying long messages outside the exception class
(TRY003)
1878-1878: Unused function argument: disaggregated_test_root
(ARG001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/qa/llm_function_core.txt (1)
785-785: New Llama‑4 disaggregated KV cache test is correctly wired into QA core listThe path, test name, and parametrization token match the new pytest test, and duplication in multiple test lists is aligned with existing QA patterns. No changes needed.
tests/integration/defs/disaggregated/test_configs/disagg_config_llama4_kv_cache_overflow.yaml (1)
1-52: Llama‑4 KV cache overflow disaggregated config looks consistent with test intent
- Model path, host/port, and UCX cache transceiver settings align with the new test and helper.
- Long context limits (max_seq_len / max_input_len) are compatible with the 128k synthetic input used in genai‑perf, and the intentionally small
max_tokens_in_buffershould reliably exercise the overflow path.- Mirrored context/generation server sections keep the setup symmetric and easy to reason about.
No issues from a config correctness perspective.
tests/integration/defs/disaggregated/test_disaggregated.py (1)
268-269: Config map entry correctly registers the new Llama‑4 KV cache overflow scenarioThe
"llama4_kv_cache_overflow"mapping to 8 ranks anddisagg_config_llama4_kv_cache_overflow.yamlundertest_configs/is consistent with the new YAML file location and the way other disaggregated configs are wired.No changes needed here.
Collaborator
|
PR_Github #24886 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #24886 [ run ] completed with state |
Collaborator
Author
|
/bot reuse-pipeline |
xinhe-nv
reviewed
Nov 19, 2025
Collaborator
|
PR_Github #24964 [ reuse-pipeline ] triggered by Bot. Commit: |
xinhe-nv
approved these changes
Nov 19, 2025
reasonsolo
approved these changes
Nov 19, 2025
Collaborator
|
PR_Github #24964 [ reuse-pipeline ] completed with state |
lkomali
pushed a commit
to lkomali/TensorRT-LLM
that referenced
this pull request
Nov 19, 2025
… error (NVIDIA#9172) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: lkomali <lkomali@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have verified on 8xH200 locally.
Summary by CodeRabbit
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.