Skip to content

Conversation

@brb-nv
Copy link
Collaborator

@brb-nv brb-nv commented Nov 16, 2025

Description

Waives tests causing pre-merge to fail. Details here:
https://nvbugspro.nvidia.com/bug/5665429

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Tests
    • Added a conditional skip for specific test scenarios to address known issues.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 16, 2025

📝 Walkthrough

Walkthrough

A conditional skip is added to the test_fused_moe_alltoall_fp4 test to bypass execution when the MNNVL AlltoallMethodType is detected, referencing an unresolved bug issue.

Changes

Cohort / File(s) Summary
Test skip condition
tests/unittest/_torch/modules/test_fused_moe.py
Early skip added for MNNVL AlltoallMethodType in test_fused_moe_alltoall_fp4 with bug reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file modification with a straightforward skip condition
  • Minimal logic change, no behavioral impact on passing tests

Suggested reviewers

  • venkywonka
  • 2ez4bz
  • EmmaQiaoCh

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is minimal and incomplete. While it references an internal bug link, it lacks a proper title, detailed explanation of the issue, and doesn't follow the expected format with clearly defined sections. Add a PR title following the template format [ticket-id][type] Summary. Provide a more detailed description explaining what is being waived and why, beyond the internal bug link.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Waive failing tests blocking pre-merge' directly matches the main change: skipping a failing test for the MNNVL AlltoallMethodType to unblock pre-merge validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv brb-nv force-pushed the user/brb/waive-tests-11-15 branch from bd1b502 to c8960b5 Compare November 16, 2025 03:09
@brb-nv
Copy link
Collaborator Author

brb-nv commented Nov 16, 2025

/bot skip --comment "Unblocking pre-merge CI"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24663 [ skip ] triggered by Bot. Commit: c8960b5

@brb-nv brb-nv enabled auto-merge (squash) November 16, 2025 03:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24663 [ skip ] completed with state SUCCESS. Commit: c8960b5
Skipping testing for commit c8960b5

@brb-nv brb-nv force-pushed the user/brb/waive-tests-11-15 branch from c8960b5 to 9c924c6 Compare November 16, 2025 04:14
@brb-nv brb-nv requested review from Funatiq and yweng0828 November 16, 2025 04:15
@brb-nv brb-nv force-pushed the user/brb/waive-tests-11-15 branch from 9c924c6 to 821120e Compare November 16, 2025 08:29
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@brb-nv brb-nv force-pushed the user/brb/waive-tests-11-15 branch from 821120e to 3a2d840 Compare November 16, 2025 08:33
@brb-nv
Copy link
Collaborator Author

brb-nv commented Nov 16, 2025

/bot skip --comment "Unblocking pre-merge CI"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24670 [ skip ] triggered by Bot. Commit: 3a2d840

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24670 [ skip ] completed with state SUCCESS. Commit: 3a2d840
Skipping testing for commit 3a2d840

@brb-nv brb-nv merged commit 6323749 into NVIDIA:main Nov 16, 2025
7 checks passed
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Nov 19, 2025
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
greg-kwasniewski1 pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 20, 2025
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants