Skip to content

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Nov 16, 2025

Summary by CodeRabbit

  • Refactor
    • Streamlined application initialization with improved dependency loading efficiency, resulting in faster startup times with no functional changes.

Description

avoid loading auto_deploy code by default in trtllm-serve and trtllm-bench to avoid affecting production-grade software path with pytorch backend

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
@lucaslie lucaslie self-assigned this Nov 16, 2025
@lucaslie lucaslie requested a review from a team as a code owner November 16, 2025 19:28
@lucaslie lucaslie added the AutoDeploy <NV> AutoDeploy Backend label Nov 16, 2025
@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Nov 16, 2025
@lucaslie
Copy link
Member Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 16, 2025

📝 Walkthrough

Walkthrough

The changes defer importing AutoDeployLLM from module initialization to runtime, moving imports from top-level to local scope within conditional branches where the autodeploy backend is used. Public APIs and signatures remain unchanged.

Changes

Cohort / File(s) Summary
Lazy import refactoring
tensorrt_llm/bench/benchmark/__init__.py, tensorrt_llm/commands/serve.py
Moved AutoDeployLLM import from top-level to local import inside conditional branches—get_llm's _autodeploy branch and launch_server's backend check—deferring initialization until the autodeploy backend is actually used.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Both changes follow an identical pattern of moving conditional imports to defer module loading.
  • No logic modifications or API changes.
  • Straightforward refactoring with minimal risk of unintended side effects.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description contains the required sections (Description, Test Coverage, PR Checklist) but critical sections are incomplete or missing detailed information. Complete the Test Coverage section by listing specific tests that validate the lazy import changes. Add a proper PR title following the template format [ticket][type] Summary. Clarify the rationale for avoiding AutoDeploy code loading by default.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: moving AutoDeploy imports to be local imports in serve.py and bench/init.py for deferred loading.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24691 [ run ] triggered by Bot. Commit: cbfacbd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24691 [ run ] completed with state SUCCESS. Commit: cbfacbd
/LLM/main/L0_MergeRequest_PR pipeline #18646 completed with status: 'FAILURE'

@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24702 [ run ] triggered by Bot. Commit: cbfacbd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24702 [ run ] completed with state FAILURE. Commit: cbfacbd
/LLM/main/L0_MergeRequest_PR pipeline #18656 completed with status: 'FAILURE'

@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24773 [ run ] triggered by Bot. Commit: cbfacbd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24773 [ run ] completed with state SUCCESS. Commit: cbfacbd
/LLM/main/L0_MergeRequest_PR pipeline #18690 completed with status: 'SUCCESS'

@qiaoxj07 qiaoxj07 merged commit 6d0a8ed into NVIDIA:main Nov 18, 2025
9 of 11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Nov 18, 2025
@lucaslie lucaslie deleted the ll/local_ad_imports branch November 18, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoDeploy <NV> AutoDeploy Backend

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants