[https://nvbugs/5670793][fix] Solve trtllm-serve launch_disaggregated issue #9346
Conversation
xxi-nv
requested review from
JunyiXu-nv,
Shixiaowei02,
hchings and
longlee0622
|
/bot run |
📝 WalkthroughWalkthroughRefactors inter-process communication mechanism from TCP ports to IPC addresses. Introduces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tensorrt_llm/commands/serve.py (1)
702-706: Update or remove the outdated TODO comment.The TODO comment about atomic port allocation is no longer relevant since the code now uses IPC addresses instead of TCP ports. IPC addresses generated with UUIDs don't have the same race condition concerns as port allocation.
The implementation itself is correct and properly uses
find_free_ipc_addr()to generate a unique IPC address.- # This mimics the behavior of trtllm-llmapi-launch - # TODO: Make the port allocation atomic free_ipc_addr = find_free_ipc_addr() os.environ[LlmLauncherEnvs.TLLM_SPAWN_PROXY_PROCESS] = "1" os.environ[ LlmLauncherEnvs.TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR.value] = free_ipc_addr
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tensorrt_llm/commands/serve.py(2 hunks)tensorrt_llm/llmapi/mpi_session.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tensorrt_llm/commands/serve.py (2)
tensorrt_llm/llmapi/mpi_session.py (1)
find_free_ipc_addr(544-548)tensorrt_llm/executor/utils.py (1)
LlmLauncherEnvs(22-29)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tensorrt_llm/commands/serve.py (1)
31-31: LGTM!The import change correctly reflects the switch from TCP port allocation to IPC address generation.
tensorrt_llm/llmapi/mpi_session.py (1)
544-548: Add cleanup mechanism for IPC socket files and improve documentation.The function generates IPC socket file paths but doesn't provide a cleanup mechanism. These socket files can accumulate in the temp directory over time, potentially causing disk space issues or permission conflicts if a UUID collision occurs across different runs.
Consider:
- Adding a docstring that documents the return format and cleanup expectations
- Implementing cleanup via atexit handlers or context managers where the IPC address is used
- Adding error handling for cases where
tempfile.gettempdir()might fail or be non-writabledef find_free_ipc_addr() -> str: + """Generate a unique IPC address for inter-process communication. + + Returns: + str: IPC address in the format 'ipc://<tempdir>/rpc_<uuid>' + + Note: + Caller is responsible for cleaning up the socket file after use. + """ import os import tempfile import uuid return f'ipc://{os.path.join(tempfile.gettempdir(), "rpc_" + str(uuid.uuid4()))}'Additionally, verify whether socket cleanup is handled elsewhere in the codebase:
|
PR_Github #25264 [ run ] triggered by Bot. Commit: |
longlee0622
changed the title
|
PR_Github #25264 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #25296 [ run ] triggered by Bot. Commit: |
|
L0 is failing on deepgemm clone, should be fixed by: #9349 Need rebase/rerun after that PR... |
|
PR_Github #25296 [ run ] completed with state |
Signed-off-by: xxi <xxi@nvidia.com>
|
/bot run |
|
PR_Github #25640 [ run ] triggered by Bot. Commit: |
|
PR_Github #25640 [ run ] completed with state |
4 participants
Description
This is a cherry-pick from #9324 to fix the similar issue on main.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.