Skip to content

Conversation

@AAnoosheh
Copy link
Contributor

@AAnoosheh AAnoosheh commented Nov 21, 2025

What does this PR do?

Type of change: ? Bug fix

Overview: Filter out KD state from ModelOpt state list when saving. This allows for applying the KD mode after a modelopt checkpoint restore without it complaining that it was already applied previously.

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
@AAnoosheh AAnoosheh self-assigned this Nov 21, 2025
@AAnoosheh AAnoosheh requested review from a team as code owners November 21, 2025 13:45
@AAnoosheh AAnoosheh requested a review from realAsma November 21, 2025 13:45
@AAnoosheh AAnoosheh changed the title Aanoosheh/selective restore Selective Mode restoration Nov 21, 2025
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
@AAnoosheh AAnoosheh force-pushed the aanoosheh/selective-restore branch from 6f61222 to 929d07a Compare November 21, 2025 15:06
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
@AAnoosheh AAnoosheh force-pushed the aanoosheh/selective-restore branch from 929d07a to d4883ed Compare November 21, 2025 15:10
@AAnoosheh AAnoosheh changed the title Selective Mode restoration Selective mode saving Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.46%. Comparing base (38550b0) to head (d4883ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   74.45%   74.46%           
=======================================
  Files         182      182           
  Lines       18250    18255    +5     
=======================================
+ Hits        13588    13593    +5     
  Misses       4662     4662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@realAsma realAsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR to unblock merging for the release.
Attaching the teacher model design was not a good choice looking back - it is creating lot of headaches. We should just deal with distillation with the loss function or trainer.

We dont need to necessarily need to remove the mtd.convert - but stop maintaining it and use a trainer/loss function based distillation support -

QAT + distillation is a critical piece going forward - It would be great to simplify things - If any design choices turned out problematic - we dont have to keep patching it - we could redirect our energy for a better design.

Cc @kevalmorabia97 @jenchen13 @ChenhanYu

@AAnoosheh AAnoosheh merged commit 01e24fd into main Nov 21, 2025
27 checks passed
@AAnoosheh AAnoosheh deleted the aanoosheh/selective-restore branch November 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants