Skip to content

Fix interface issues in Fortran module with gfortran. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romerojosh merged 1 commit into from
Aug 30, 2024
Merged

Fix interface issues in Fortran module with gfortran. #18

romerojosh merged 1 commit into from
Aug 30, 2024

Conversation

@romerojosh
Copy link
Collaborator

@romerojosh romerojosh commented Aug 30, 2024

Fixing some compilation issues of the Torchfort module with gfortran:

  1. Missing an ignore_arg_check directive on loss_val in torchfort_train_c.
  2. Incorrect array dimensions for act in torchfort_rl_off_policy_predict_float_4d_2d leading to an ambiguous interface.

@romerojosh romerojosh requested a review from azrael417 August 30, 2024 18:56
azrael417
azrael417 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@azrael417 azrael417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for fixing this

@romerojosh romerojosh merged commit 73fe01f into master Aug 30, 2024
@romerojosh romerojosh deleted the fix_fortran_gfortran branch September 30, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azrael417 azrael417 azrael417 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romerojosh @azrael417