Skip to content

Conversation

@ksivaman
Copy link
Member

@ksivaman ksivaman commented Oct 8, 2025

Description

We have a minimum python version requirement for our build (currently v3.8) but no way of checking whether new changes introduced violate this rule, e.g:

Instead of changing the functionality to not use these features, I've taken the opportunity to update the minimum required python version to v3.10 since python v3.8 is at end of life (and v3.9 will also be by the end of the month) .

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Update minimum python version requirement to 3.10.
  • Add python version requirements to the framework's setup.pys.
  • Use a pre-commit hook to catch changes that violate the minimum version requirement.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman ksivaman requested review from ptrendx and timmoon10 October 8, 2025 02:15
@ksivaman
Copy link
Member Author

ksivaman commented Oct 8, 2025

/te-ci

@ksivaman
Copy link
Member Author

ksivaman commented Oct 8, 2025

Pipeline 36220067

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version checks will be nice, but I'm uncertain how much we can rely on vermin. It's being developed by an individual, the last release was 2 years ago, and I'm unsure if it has had serious adoption by other projects. See this discussion from postmarketOS.

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
Copy link
Member Author

ksivaman commented Oct 8, 2025

/te-ci

@ksivaman ksivaman requested a review from timmoon10 October 8, 2025 20:57
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
Copy link
Member Author

ksivaman commented Oct 8, 2025

/te-ci

@ksivaman ksivaman merged commit e99be1b into NVIDIA:main Oct 9, 2025
37 of 41 checks passed
pggPL pushed a commit to pggPL/TransformerEngine that referenced this pull request Oct 15, 2025
* Update minimum python version to 3.10 and update CI

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>

* review

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>

* fix

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>

---------

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants