-
Notifications
You must be signed in to change notification settings - Fork 32
Add security page #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security page #161
Conversation
Documentation preview |
|
|
||
|
|
||
|
|
||
| CVEs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think a table like this is useful? Are their other fields we should maintain in our docs (all the CVE info is also in the linked bulletins)
There are a few more of these CVEs that relate to vulnerabilities in images used in older version. For completeness, we should probably include them as well, but i wanted to make sure that the table was valuable before i went to the trouble of adding all the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is valuable. I don't think we should add any more information to this table though. The security bulletin should be the source of truth and readers should be redirected there if they want more information about any particular CVE.
cdesiniotis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-mccarthy Thanks for this PR! I am good with these changes, but I would like to get another opinion on the table contents.
|
|
||
|
|
||
|
|
||
| CVEs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is valuable. I don't think we should add any more information to this table though. The security bulletin should be the source of truth and readers should be redirected there if they want more information about any particular CVE.
gpu-operator/security.rst
Outdated
|
|
||
| - Access to the host file system and hardware devices, such as NVIDIA GPUs. | ||
| - Restart system services such as containerd. | ||
| - Permit users to list all GPU clients using the ``nvidia-smi`` utility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a valid reason:
Permit users to list all GPU clients using the ``nvidia-smi`` utility.
Let's add Loading and unloading kernel modules to the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. i removed the permit line and added a line for loading and unloading kernel modules
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
7d81dff to
7286e97
Compare
Part of #155